-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linea): support token detection on linea mainnet and linea goerli networks #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i networks The token detection feature requires to deploy BalanceChecker smart contract (available on https://github.com/wbobeirne/eth-balance-checker) and indicate address of deployed contract in AssetsContractController.ts
Merged
8 tasks
cryptodev-2s
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…i networks (#1799) ## Explanation The purpose of this PR is to enable token detection on Linea Mainnet and Linea Goerli networks. [BalanceChecker](https://github.com/wbobeirne/eth-balance-checker) smart contract has been deployed on both networks and its address needs to be indicated in AssetsContractController.ts. ## References * Unblocks MetaMask/metamask-extension#20698 ## Changelog ### `'@metamask/assets-controllers` - **ADDED**: Support token detection on Linea Mainnet and Linea Goerli networks ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…i networks (#1799) ## Explanation The purpose of this PR is to enable token detection on Linea Mainnet and Linea Goerli networks. [BalanceChecker](https://github.com/wbobeirne/eth-balance-checker) smart contract has been deployed on both networks and its address needs to be indicated in AssetsContractController.ts. ## References * Unblocks MetaMask/metamask-extension#20698 ## Changelog ### `'@metamask/assets-controllers` - **ADDED**: Support token detection on Linea Mainnet and Linea Goerli networks ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
…i networks (#1799) ## Explanation The purpose of this PR is to enable token detection on Linea Mainnet and Linea Goerli networks. [BalanceChecker](https://github.com/wbobeirne/eth-balance-checker) smart contract has been deployed on both networks and its address needs to be indicated in AssetsContractController.ts. ## References * Unblocks MetaMask/metamask-extension#20698 ## Changelog ### `'@metamask/assets-controllers` - **ADDED**: Support token detection on Linea Mainnet and Linea Goerli networks ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The purpose of this PR is to enable token detection on Linea Mainnet and Linea Goerli networks.
BalanceChecker smart contract has been deployed on both networks and its address needs to be indicated in AssetsContractController.ts.
References
Changelog
'@metamask/assets-controllers
Checklist