Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linea): support token detection on linea mainnet and linea goerli networks #1799

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Oct 10, 2023

Explanation

The purpose of this PR is to enable token detection on Linea Mainnet and Linea Goerli networks.
BalanceChecker smart contract has been deployed on both networks and its address needs to be indicated in AssetsContractController.ts.

References

Changelog

'@metamask/assets-controllers

  • ADDED: Support token detection on Linea Mainnet and Linea Goerli networks

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

…i networks

The token detection feature requires to deploy BalanceChecker smart contract (available on https://github.com/wbobeirne/eth-balance-checker) and indicate address of deployed contract in AssetsContractController.ts
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauthierpetetin gauthierpetetin merged commit deb9317 into main Oct 10, 2023
107 checks passed
@gauthierpetetin gauthierpetetin deleted the feat/linea-token-detection branch October 10, 2023 16:00
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
…i networks (#1799)

## Explanation

The purpose of this PR is to enable token detection on Linea Mainnet and
Linea Goerli networks.
[BalanceChecker](https://github.com/wbobeirne/eth-balance-checker) smart
contract has been deployed on both networks and its address needs to be
indicated in AssetsContractController.ts.

## References

* Unblocks MetaMask/metamask-extension#20698

## Changelog

### `'@metamask/assets-controllers`

- **ADDED**: Support token detection on Linea Mainnet and Linea Goerli
networks

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
…i networks (#1799)

## Explanation

The purpose of this PR is to enable token detection on Linea Mainnet and
Linea Goerli networks.
[BalanceChecker](https://github.com/wbobeirne/eth-balance-checker) smart
contract has been deployed on both networks and its address needs to be
indicated in AssetsContractController.ts.

## References

* Unblocks MetaMask/metamask-extension#20698

## Changelog

### `'@metamask/assets-controllers`

- **ADDED**: Support token detection on Linea Mainnet and Linea Goerli
networks

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
MajorLift pushed a commit that referenced this pull request Oct 12, 2023
…i networks (#1799)

## Explanation

The purpose of this PR is to enable token detection on Linea Mainnet and
Linea Goerli networks.
[BalanceChecker](https://github.com/wbobeirne/eth-balance-checker) smart
contract has been deployed on both networks and its address needs to be
indicated in AssetsContractController.ts.

## References

* Unblocks MetaMask/metamask-extension#20698

## Changelog

### `'@metamask/assets-controllers`

- **ADDED**: Support token detection on Linea Mainnet and Linea Goerli
networks

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants