eth-json-rpc-provider migration - B4: Add exceptions in constraints.pro for ISC license.
#1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion targets with non-MIT licenses. - This commit adds `eth-json-rpc-provider` as an exception that uses the ISC license. - Further exceptions that use the ISC license can be added by appending to both rules in the form of: `,\n[CONDITION].\n` - Adding exception clauses for a third non-MIT/ISC license is not recommended, as it will require complex changes.
15 tasks
MajorLift
added a commit
that referenced
this pull request
Oct 12, 2023
…s.pro` for ISC license. (#1767) ## Explanation This PR implements the following incremental step in the process for migrating `eth-json-rpc-provider` into the core monorepo: *** ### Phase B: Staging in `migrated-packages/` #### 4. Add exception for non-MIT license. - [x] If migration target uses a non-MIT license, add exception entries in the root `constraints.pro` file. - [x] Make sure the new rule doesn't break any of the existing package.json files by running `yarn constraints`. *** See #1551 (comment) for an outline of the entire process. ## References - Contributes to #1685 - Contributes to #1551 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR implements the following incremental step in the process for migrating
eth-json-rpc-providerinto the core monorepo:Phase B: Staging in
migrated-packages/4. Add exception for non-MIT license.
constraints.profile.yarn constraints.See #1551 (comment) for an outline of the entire process.
References
@metamask/eth-json-rpc-providerto core monorepo #1685eth-json-rpc-providerinto core monorepo #1551Changelog
N/A
Checklist