Parameterize TokenListController by NetworkClientId + Integrate PollingController
#1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
tokenlistcontroller-multichain
branch
2 times, most recently
from
c9b92b0
to
07bc063
Compare
adonesky1
force-pushed
the
tokenlistcontroller-multichain
branch
from
1b8bf7f
to
57b2884
Compare
adonesky1
changed the title
TokenListController by NetworkClientId + Integrate PollingController
adonesky1
force-pushed
the
tokenlistcontroller-multichain
branch
from
c29085d
to
e10b445
Compare
jiexi
reviewed
Oct 6, 2023
adonesky1
force-pushed
the
tokenlistcontroller-multichain
branch
from
73ff166
to
3ff7eee
Compare
jiexi
approved these changes
Oct 6, 2023
shanejonas
approved these changes
Oct 10, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…PollingController` (#1763) Resolves: MetaMask/MetaMask-planning#1032 Integrates new `PollingController` abstraction into the `TokenListController`, implements the `executePoll` method and parameterizes the `fetchTokenList` method by `networkClientId` such that tokenLists can be fetched and cached for different networks via concurrent polling sessions. **A note:** As is our current controller refactor strategy, these changes are additive, backwards compatible and coexist alongside the existing globally selected network pattern. Once we fully adopt this polling pattern we should no longer access the root `tokenList` state but rather access from the cache with a chainId selector.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…PollingController` (#1763) Resolves: MetaMask/MetaMask-planning#1032 Integrates new `PollingController` abstraction into the `TokenListController`, implements the `executePoll` method and parameterizes the `fetchTokenList` method by `networkClientId` such that tokenLists can be fetched and cached for different networks via concurrent polling sessions. **A note:** As is our current controller refactor strategy, these changes are additive, backwards compatible and coexist alongside the existing globally selected network pattern. Once we fully adopt this polling pattern we should no longer access the root `tokenList` state but rather access from the cache with a chainId selector.
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
…PollingController` (#1763) Resolves: MetaMask/MetaMask-planning#1032 Integrates new `PollingController` abstraction into the `TokenListController`, implements the `executePoll` method and parameterizes the `fetchTokenList` method by `networkClientId` such that tokenLists can be fetched and cached for different networks via concurrent polling sessions. **A note:** As is our current controller refactor strategy, these changes are additive, backwards compatible and coexist alongside the existing globally selected network pattern. Once we fully adopt this polling pattern we should no longer access the root `tokenList` state but rather access from the cache with a chainId selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/MetaMask/MetaMask-planning/issues/1032
Integrates new
PollingControllerabstraction into theTokenListController, implements theexecutePollmethod and parameterizes thefetchTokenListmethod bynetworkClientIdsuch that tokenLists can be fetched and cached for different networks via concurrent polling sessions.A note: As is our current controller refactor strategy, these changes are additive, backwards compatible and coexist alongside the existing globally selected network pattern. Once we fully adopt this polling pattern we should no longer access the root
tokenListstate but rather access from the cache with a chainId selector.Added
PollingControllermixin into theTokenListControllerand implements the abstractexecutePollmethod.Changed
networkClientIdargument tofetchTokenListmethod onTokenListControllerwhich, if passed, is used fetch the chainId that corresponds to thenetworkClientIdand is then used to fetch and cache the appropriatetokenList.