[assets-controllers] TokenDetectionController uses the wrong token list #3905
Assignees
Labels
Comments
|
Hey team! Please add your planning poker estimate with Zenhub @BelfordZ @jiexi @shanejonas |
Merged
3 tasks
jiexi
added a commit
that referenced
this issue
Feb 20, 2024
…assed networkClientId (#3914) ## Explanation Currently, `detectTokens()` always uses the state for the globally selected network from the `TokenListController` and `TokensController` regardless of if/what networkClientId is passed in. This PR updates `detectTokens()` to use the chainId keyed states of the `TokenListController` and `TokensController` instead. ## References Fixes: #3905 ## Changelog ### `@metamask/assets-controllers` - **FIXED**: `TokenDetectionController.detectTokens()` now reads the chainId keyed state properties from `TokenListController` and `TokensController` rather than incorrectly using the globally selected state properties when networkClientId is passed ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Alex Donesky <[email protected]> Co-authored-by: Jongsun Suh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The TokenDetectionController will always use the token list for the current globally selected network, even when detecting tokens on a different network. Effectively it won't work when polling non-selected networks.
We should update the controller to use the token list for the network we're detecting tokens on.
The text was updated successfully, but these errors were encountered: