Skip to content

Commit

Permalink
fix(TXL-399): Use contract abi to decode the amounts of token balance…
Browse files Browse the repository at this point in the history
… changes (#4775)

## Explanation
* Use contract abi's to decode the amounts of token balance changes
– instead of the raw output from a balanceOf call.

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

* Fixes: MetaMask/metamask-extension#26521

## Changelog

<!--
If you're making any consumer-facing changes, list those changes here as
if you were updating a changelog, using the template below as a guide.

(CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
FIXED. For security-related issues, follow the Security Advisory
process.)

Please take care to name the exact pieces of the API you've added or
changed (e.g. types, interfaces, functions, or methods).

If there are any breaking changes, make sure to offer a solution for
consumers to follow once they upgrade to the changes.

Finally, if you're only making changes to development scripts or tests,
you may replace the template below with "None".
-->

### `@metamask/transaction-controller`

- **FIXED**: Use contract abi's to decode the amounts of token balance
changes – instead of the raw output from a balanceOf call.
## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
  • Loading branch information
dbrans authored Oct 15, 2024
1 parent 3f1d4c1 commit 7aff044
Show file tree
Hide file tree
Showing 3 changed files with 192 additions and 114 deletions.
6 changes: 3 additions & 3 deletions packages/transaction-controller/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ module.exports = merge(baseConfig, {
coverageThreshold: {
global: {
branches: 94.42,
functions: 97.46,
lines: 98.44,
statements: 98.46,
functions: 97.45,
lines: 98.37,
statements: 98.38,
},
},

Expand Down
Loading

0 comments on commit 7aff044

Please sign in to comment.