Change the types for BaseControllerV1 class fields initialConfig,…

… `initialState` from `C`, `S` to `Partial<C>`, `Partial<S>`
MetaMask · Feb 22, 2024 · 6ab2e37 · 6ab2e37
1 parent 0bd4386
commit 6ab2e37
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/base-controller/CHANGELOG.md b/packages/base-controller/CHANGELOG.md
@@ -9,7 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
-- **BREAKING:** Convert `BaseConfig`, `BaseState` interfaces to types.
+- **BREAKING:** Change the types for `BaseControllerV1` class fields `initialConfig`, `initialState` from `C`, `S` to `Partial<C>`, `Partial<S>` ([#3959](https://github.com/MetaMask/core/pull/3959))
+- **BREAKING:** Convert `BaseConfig`, `BaseState` interfaces to types ([#3959](https://github.com/MetaMask/core/pull/3959))
   - As types, `BaseConfig`, `BaseState` now extend `Record` and have an index signature of `string`.
 
 ## [4.1.1]

diff --git a/packages/base-controller/src/BaseControllerV1.ts b/packages/base-controller/src/BaseControllerV1.ts
@@ -53,9 +53,9 @@ export class BaseControllerV1<C extends BaseConfig, S extends BaseState> {
    */
   name = 'BaseController';
 
-  private readonly initialConfig: C;
+  private readonly initialConfig: Partial<C>;
 
-  private readonly initialState: S;
+  private readonly initialState: Partial<S>;
 
   private internalConfig: C = this.defaultConfig;
 
@@ -71,8 +71,8 @@ export class BaseControllerV1<C extends BaseConfig, S extends BaseState> {
    * @param state - Initial state to set on this controller.
    */
   constructor(config: Partial<C> = {}, state: Partial<S> = {}) {
-    this.initialState = { ...(state as S) };
-    this.initialConfig = { ...(config as C) };
+    this.initialState = { ...state };
+    this.initialConfig = { ...config };
   }
 
   /**