Skip to content
Main

Override subscriptionManager.middleware.destroy to also remove sub entry #13590

Sign in to view logs

Override subscriptionManager.middleware.destroy to also remove sub entry

Override subscriptionManager.middleware.destroy to also remove sub entry #13590

Triggered via pull request November 27, 2024 20:32
@jiexijiexi
synchronize #4984
jl/caip-multichain/subscription-middleware-destroy
Status Failure
Total duration 3m 50s
Artifacts –

main.yml

on: pull_request
Check workflows
7s
Check workflows
Matrix: Lint, build, and test / Prepare
Matrix: Lint, build, and test / Build
Matrix: Lint, build, and test / Lint
Matrix: Lint, build, and test / Test
Matrix: Lint, build, and test / Validate changelog
Determine whether this is a release merge commit
0s
Determine whether this is a release merge commit
All jobs complete
0s
All jobs complete
Publish release  /  publish-release
Publish release / publish-release
All jobs pass
0s
All jobs pass
Publish release  /  publish-npm-dry-run
Publish release / publish-npm-dry-run
Publish release  /  publish-npm
Publish release / publish-npm
Create update issues  /  create-update-issues
Create update issues / create-update-issues
Fit to window
Zoom out
Zoom in

Annotations

68 errors
Lint, build, and test / Test (18.x, @metamask/multichain)
Process completed with exit code 1.
Lint, build, and test / Test (20.x, @metamask/controller-utils)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/permission-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/message-manager)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/name-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/json-rpc-engine)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/chain-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/chain-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/multichain)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/multichain)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/gas-fee-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/gas-fee-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/message-manager)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/json-rpc-engine)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/json-rpc-engine)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/phishing-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/phishing-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/phishing-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/phishing-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/queued-request-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/queued-request-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/signature-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/signature-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/base-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/base-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/queued-request-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/queued-request-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/signature-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/signature-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/user-operation-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/user-operation-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/user-operation-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/user-operation-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/keyring-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/keyring-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/keyring-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/keyring-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/profile-sync-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/profile-sync-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/network-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/network-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/assets-controllers)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/assets-controllers)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/notification-services-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/notification-services-controller)
The operation was canceled.
Lint, build, and test / Test (18.x, @metamask/transaction-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (18.x, @metamask/transaction-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/profile-sync-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/profile-sync-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/transaction-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/transaction-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/assets-controllers)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/assets-controllers)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/network-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/network-controller)
The operation was canceled.
Lint, build, and test / Test (20.x, @metamask/notification-services-controller)
The job was canceled because "_18_x__metamask_multichai" failed.
Lint, build, and test / Test (20.x, @metamask/notification-services-controller)
The operation was canceled.
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L10
All imports in the declaration are only used as types. Use `import type`
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L10
There should be at least one empty line between import groups
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L11
'yargs' should be listed in the project's dependencies. Run 'npm i -S yargs' to add it
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L11
`yargs` import should occur before import of `../scope/types`
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L11
'middleware' is defined but never used
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L11
"yargs" is extraneous
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L98
Insert `;`
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L117
'middleware' is already declared in the upper scope on line 11 column 10
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L118
Replace `res,next,end)` with `·res,·next,·end);`
Lint, build, and test / Lint (20.x): packages/multichain/src/middlewares/MultichainSubscriptionManager.ts#L128
Replace `⏎······this,⏎······newSubscriptionEntry⏎····` with `this,·newSubscriptionEntry`
All jobs pass
Process completed with exit code 1.