Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export isVaultUpdated function #53

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Export isVaultUpdated function #53

merged 1 commit into from
Nov 23, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Nov 15, 2023 •
edited
Loading

This PR exports the isVaultUpdate function, to give clients the option to know if a vault is up to date, as opposed to updating it directly with updateVault.

See: MetaMask/core#3582

@mikesposito mikesposito requested review from a team as code owners November 15, 2023 13:13
Gudahtt
Gudahtt approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit a44c69c into main Nov 23, 2023
16 checks passed
@mikesposito mikesposito deleted the feat/expose-isvaultupdated branch November 23, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesposito @Gudahtt