-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Bump prettier
to ^3.3.3
#202
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/[email protected] New author ok. @SocketSecurity ignore npm/[email protected] Shell access expected. |
e210a0c
to
e5fde30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@@ -107,7 +107,7 @@ type ValidateChangelogOptions = { | |||
* `true` and the changelog contains uncategorized changes. | |||
* @throws `ChangelogFormattingError` - Will throw if there is a formatting error. | |||
*/ | |||
export function validateChangelog({ | |||
export async function validateChangelog({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: README
should be updated with the new API (though, I believe it should be updated with other things as well i.e. node version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in a separate PR.
This bumps Prettier to
^3.3.3
, and fixes any breaking changes in Prettier.Closes #201.
Breaking changes
prettier@^3.3.3
is now a peer-dependency of this package.Changelog.toString
now returns aPromise
, which resolves with the formatted changelog.