Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions to match module template #125

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 4, 2022

The GitHub actions have been updated to match the latest used in the module template, with some exceptions. The require-additional-reviewer action was omitted because it's broken for forks, and the documentation-related steps have been omitted because this repository does not yet have API documentation.

See: https://github.com/MetaMask/metamask-module-template/tree/a3b2e531a7961ccc32577ac3c49aa651a14623cd/.github/workflows

@Gudahtt Gudahtt marked this pull request as ready for review November 4, 2022 22:43
@Gudahtt Gudahtt requested a review from a team as a code owner November 4, 2022 22:43
The GitHub actions have been updated to match the latest used in the
module template, with some exceptions. The require-additional-reviewer
action was omitted because it's broken for forks, and the
documentation-related steps have been omitted because this repository
does not yet have API documentation.

The build has also been included in the lint step, because the
changelog linting relies upon the built `auto-changelog` tool.

See: https://github.com/MetaMask/metamask-module-template/tree/a3b2e531a7961ccc32577ac3c49aa651a14623cd/.github/workflows
@Gudahtt Gudahtt force-pushed the update-github-actions branch from 9414530 to 4ca2100 Compare November 4, 2022 22:49
@Gudahtt Gudahtt merged commit ba6a56f into main Nov 5, 2022
@Gudahtt Gudahtt deleted the update-github-actions branch November 5, 2022 14:28
Gudahtt added a commit that referenced this pull request Nov 7, 2022
This fixes a mistake made in #125, where the `prepack.sh` script was
accidentally added as a non-executable file.
Gudahtt added a commit that referenced this pull request Nov 7, 2022
This fixes a mistake made in #125, where the `prepack.sh` script was
accidentally added as a non-executable file.
Gudahtt added a commit that referenced this pull request Nov 9, 2022
The publishing instructions in the README have been updated to reflect
changes introduced in #125. We forgot to update the README in that PR.

The release instructions should now match those in the module template.
Gudahtt added a commit that referenced this pull request Nov 9, 2022
The publishing instructions in the README have been updated to reflect
changes introduced in #125. We forgot to update the README in that PR.

The release instructions should now match those in the module template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants