Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript to the latest stable version #124

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 4, 2022

TypeScript has been updated to the latest stable version. Additionally, the version range has been updated to use ~ because TypeScript does not follow SemVer (they make breaking changes as minor updates).

The configuration has been updated to match the module template, except that two options (exactOptionalPropertyTypes and noUncheckedIndexedAccess) have been omitted temporarily to reduce the number of changes required for this update. They can be added in later PRs.

Just as in the module template, a separate tsconfig file has been created to distinguish build settings from settings used to compile unit tests.

The one configuration difference is the compilation target. The target is ES2019 here because this is a developer tool, so we don't need to stick to ES2017 for browser compatibility.

@Gudahtt Gudahtt force-pushed the update-typescript branch 2 times, most recently from 99edc6e to 0ccd6a7 Compare November 7, 2022 22:27
@Gudahtt Gudahtt marked this pull request as ready for review November 7, 2022 22:32
@Gudahtt Gudahtt requested a review from a team as a code owner November 7, 2022 22:32
@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 7, 2022

Issue created here to track the additional TypeScript options: #127

src/cli.ts Outdated Show resolved Hide resolved
TypeScript has been updated to the latest stable version. Additionally,
the version range has been updated to use `~` because TypeScript does
not follow SemVer (they make breaking changes as minor updates).

The configuration has been updated to match the module template, except
that two options (`exactOptionalPropertyTypes` and
`noUncheckedIndexedAccess`) have been omitted temporarily to reduce the
number of changes required for this update. They can be added in later
PRs.

Just as in the module template, a separate `tsconfig` file has been
created to distinguish build settings from settings used to compile
unit tests.

The one configuration difference is the compilation target. The target
is ES2019 here because this is a developer tool, so we don't need to
stick to ES2017 for browser compatibility.

[1]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/
@Gudahtt Gudahtt merged commit 811ddca into main Nov 8, 2022
@Gudahtt Gudahtt deleted the update-typescript branch November 8, 2022 13:27
@mcmire mcmire mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants