-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alternate tag prefixes #120
Conversation
db977ac
to
c924579
Compare
We should support alternate prefixes in version tags. At the moment the project assumes that the prefix v is always used. But some projects use no prefix, or include the package as a prefix to the version (e.g. in monorepos). All public-facing functions now support a tag prefix option. It is optional, so this is a non-breaking change. The `updateChangelog` method accepts an array of tag prefixes instead of a single one, so that we can better support the first release of a monorepo where you might want to compare against a backup tag if the first isn't found. Fixes #116
c924579
to
8212c8e
Compare
I will follow up with manual testing steps soon, and do some manual testing myself. |
Manual testing steps: Independent repository (regression testing):
Monorepo repository (new functionality):
|
The manual testing steps include setting the This seems wrong to me (the version should always match the manifest at the project root), so I have updated how that works here: #121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM
We should support alternate prefixes in version tags. At the moment the project assumes that the prefix
v
is always used. But some projects use no prefix, or include the package as a prefix to the version (e.g. in monorepos).All public-facing functions now support a tag prefix option. It is optional, so this is a non-breaking change. The
updateChangelog
method accepts an array of tag prefixes instead of a single one, so that we can better support the first release of a monorepo where you might want to compare against a backup tag if the first isn't found.
Fixes #116