Automate shorthand major version tag updating #28
Conversation
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Update shorthand major version tag | ||
| run: ./scripts/update-major-version-tag.sh ${{ steps.publish-release.outputs.RELEASE_VERSION }} |
There was a problem hiding this comment.
I don't see RELEASE_VERSION being set as an output 🤔
There was a problem hiding this comment.
Huh. So those docs don't seem to clarify whether environment variables set are automatically considered as "outputs". That's the part I wasn't sure of. Was this shown to work before you made that change? The other shorthand major version tag updating PR still doesn't set the output explicitly.
There was a problem hiding this comment.
Oh, I missed that it was set here: https://github.com/MetaMask/action-publish-release/blob/main/scripts/get-release-version.sh#L27
Hmm. OK.
There was a problem hiding this comment.
I can confirm that the output works as expected, although I found another issue with my implementation in this PR that I address here: #30
rekmarks
force-pushed
the
automate-shorthand-major-version-tag-update
branch
from
97afa4b to
bc83f11
Compare
Automate the updating of the shorthand major version tag (e.g.
v1) at the end of the localpublish-releaseworkflow. We accomplish this by adding an output to this action namedrelease-version.