Issue994 unit tests broken and failing alot (but weirdly not always.) #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Options, commented out some tests that do not work, even though the classes are fine
petersilva
requested review from
gcglinton,
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
|
@gcglinton I thought I'd invite you to review in case the tests I had to disable are obvious to you. If they aren't feel free to ignore. Thanks! |
petersilva
changed the title
|
The change to the message generation for these tests is a good one I wrote the asserts/tests based on the code I could decipher, and assumptions I had made (like apparently using v2 message formats?). If those assumptions were wrong, then obviously the tests are also wrong. Coverage doesn't seem to be affected, so I guess all is well. Also, you've already merged it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #994
I'm puzzled about the unit tests. I thought they were working occasionally. and looking
at the history of results they seem to succeed once in a while. I started running them manually
to see why they were failing often, and found a bunch of problems. Fixed what I could figure out easily.
The most elaborate assertions were failing, and I think it is because they are asserting things that just aren't true... the failed tests don't reflect anything wrong with the classes...