Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostname setting. #967

Closed
petersilva opened this issue Mar 11, 2024 · 2 comments · Fixed by #970
Closed

hostname setting. #967

petersilva opened this issue Mar 11, 2024 · 2 comments · Fixed by #970
Assignees
Labels
bug Something isn't working regression Broke something that was working before.

Comments

@petersilva
Copy link
Contributor

Found some deployed configurations where hostname setting is a list. I think the problem is that the hostname setting processing is completely absent from sr3 and it just uses the system defined one. In v2 there are overrides, and those overrides are important because the hostname isn't always good in a cluster... so having overrides is helpful.

@petersilva petersilva added bug Something isn't working regression Broke something that was working before. labels Mar 11, 2024
@petersilva
Copy link
Contributor Author

petersilva commented Mar 11, 2024

To reproduce the issue:

fractal% sr3 add subscribe/dd_amis.conf
add: 2024-03-11 13:15:34,407 2165569 [INFO] sarracenia.sr add copying: /home/peter/Sarracenia/sr3/sarracenia/examples/subscribe/dd_amis.conf to /home/peter/.config/sr3/subscribe/dd_amis.conf 

fractal% sr3 edit subscribe/dd_amis.conf
# add a line: hostname hoho
# Add ${HOSTNAME} to the "directory" option.
# save it.
missing state for subscribe/dd_amis

fractal% sr3 show subscribe/dd_amis |& grep -i hostname
 'hostname': ['fractal', 'hoho'],
fractal% 

@petersilva
Copy link
Contributor Author

analysis:

  • in sarracenia/config.py there is a single setting of self.hostname to result of getfqdn()... there is no provision for overriding it.
  • hostname should be declared as a string option, that might be enough to fix it.
  • it does seem to be...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Broke something that was working before.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant