Merge and concatinate cubes on load #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
force-pushed
the
merge_cubes_after_load
branch
3 times, most recently
from
c9e050f to
9bea2fb
Compare
3 tasks
jfrost-mo
force-pushed
the
merge_cubes_after_load
branch
from
f9065ff to
a5bc2f1
Compare
This allows the callbacks to do their work, as the automatic merging only happens before the callbacks run. Therefore when the callbacks make the cubes compatible they are not merged. This is tested by loading cubes with UUID attributes, and ensuring they concatenate into a single cube.
jfrost-mo
force-pushed
the
merge_cubes_after_load
branch
from
a5bc2f1 to
22751b3
Compare
ukmo-huw-lewis
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the callbacks to do their work, as the automatic merging only happens before the callbacks run. Therefore when the callbacks make the cubes compatible they are not merged.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.