Unquote double quoted shell values #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrost-mo
force-pushed
the
fix_shell_quoting
branch
from
794aade to
889333f
Compare
|
|
daflack
reviewed
Jul 4, 2024
|
Ack. More investigation is needed then... |
|
There are still some issues with this method. The wrong types of quotes are being expanded, for one. |
jfrost-mo
force-pushed
the
fix_shell_quoting
branch
from
889333f to
c6a4f14
Compare
|
Should be a more complete fix now, and is hopefully also more readable? |
daflack
reviewed
Jul 4, 2024
jfrost-mo
force-pushed
the
fix_shell_quoting
branch
from
108e56e to
fb7e81a
Compare
daflack
approved these changes
Jul 5, 2024
This handles the double quoting that arises from CSET_ADDOPTS arguments never actually being parsed by a shell, and thus still having quotes.
jfrost-mo
force-pushed
the
fix_shell_quoting
branch
from
42db7c6 to
9bb5c9d
Compare
|
Rebased then merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the double quoting that arises from CSET_ADDOPTS arguments never actually being parsed by a shell.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.