Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable spatial fields on full and half levels #695

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Enable spatial fields on full and half levels #695

merged 3 commits into from
Jul 5, 2024

Conversation

Sylviabohnenstengel
Copy link
Contributor

@Sylviabohnenstengel Sylviabohnenstengel commented Jun 25, 2024 •
edited
Loading

Fixes #

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Added an entry to the top of docs/source/changelog.rst
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

Coverage

@Sylviabohnenstengel Sylviabohnenstengel mentioned this pull request Jun 26, 2024
Closed
@jfrost-mo jfrost-mo changed the title 694 enable spatial fields on full and half levels Enable spatial fields on full and half levels Jun 27, 2024
@jfrost-mo jfrost-mo changed the base branch from main to 637_lfric_extension_to_vertical_profile June 27, 2024 08:56
@jfrost-mo jfrost-mo force-pushed the 637_lfric_extension_to_vertical_profile branch 2 times, most recently from 43bf53f to 9ad955d Compare June 27, 2024 15:59
@jfrost-mo jfrost-mo added the enhancement New feature or request label Jun 28, 2024
@jfrost-mo jfrost-mo force-pushed the 637_lfric_extension_to_vertical_profile branch from 477c4ca to 10f69ee Compare July 1, 2024 10:32
Base automatically changed from 637_lfric_extension_to_vertical_profile to main July 1, 2024 14:18
@jfrost-mo jfrost-mo force-pushed the 694_enable_spatial_fields_on_full_and_half_levels branch from f2d0a98 to c31bb78 Compare July 1, 2024 14:37
jfrost-mo
jfrost-mo reviewed Jul 1, 2024
View reviewed changes
docs/source/changelog.rst Outdated Show resolved Hide resolved
@jfrost-mo
Copy link
Member

This branch has been rebased.

@jfrost-mo jfrost-mo force-pushed the 694_enable_spatial_fields_on_full_and_half_levels branch from bf496a1 to d081101 Compare July 1, 2024 15:04
@jfrost-mo jfrost-mo force-pushed the 694_enable_spatial_fields_on_full_and_half_levels branch from d081101 to 3bdf9be Compare July 4, 2024 14:59
@Sylviabohnenstengel Sylviabohnenstengel self-assigned this Jul 4, 2024
@Sylviabohnenstengel Sylviabohnenstengel marked this pull request as ready for review July 4, 2024 16:00
jfrost-mo
jfrost-mo approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll go ahead and merge.

@jfrost-mo jfrost-mo merged commit c7efcbc into main Jul 5, 2024
7 checks passed
@jfrost-mo jfrost-mo deleted the 694_enable_spatial_fields_on_full_and_half_levels branch July 5, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees

@Sylviabohnenstengel Sylviabohnenstengel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sylviabohnenstengel @jfrost-mo