Publish formula through canonical Homebrew tap - #11
Merged
Conversation
📝 WalkthroughWalkthroughHomebrew formula metadata and release validation were updated, while project documentation now describes canonical tap publication, installation, synchronization, and packaging readiness status. ChangesHomebrew publication
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/publishing.md`:
- Around line 14-21: Update the Homebrew channel description in the publishing
documentation to state that the formula supports Apple Silicon macOS only and
that Intel macOS is unsupported. Keep the existing immutable archive,
verification, polling, and commit behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 71b0e24d-f898-4e49-987f-0434e5b7dae8
📒 Files selected for processing (7)
.github/workflows/images-release.ymlREADME.mddocs/packaging-readiness-gaps.mddocs/packaging-readiness-scorecard.mddocs/publishing.mdpackaging/homebrew/Formula/mesh-llm.rb.templatepackaging/homebrew/README.md
💤 Files with no reviewable changes (1)
- packaging/homebrew/Formula/mesh-llm.rb.template
Comment on lines
+14
to
+21
| GitHub Release assets, GHCR, npm, and the | ||
| [`Mesh-LLM/tap`](https://github.com/Mesh-LLM/homebrew-tap) Homebrew tap are the | ||
| enabled public channels. Do not create apt, apk, or pacman repositories until | ||
| signing/trust-root ownership and rollback procedures exist. Homebrew publishes | ||
| a formula that references the immutable upstream macOS archive and its | ||
| upstream-verified SHA256; it does not repackage that binary. The tap polls this | ||
| repository's latest non-prerelease packaging release, validates and installs | ||
| the attached `mesh-llm.rb`, and commits it only when it changes. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Document the Homebrew platform limitation here.
This newly enabled channel should explicitly say that the formula supports Apple Silicon only and that Intel macOS is unsupported; currently that limitation is documented only in packaging/homebrew/README.md.
Suggested wording
GitHub Release assets, GHCR, npm, and the
[`Mesh-LLM/tap`](https://github.com/Mesh-LLM/homebrew-tap) Homebrew tap are the
enabled public channels. Do not create apt, apk, or pacman repositories until
signing/trust-root ownership and rollback procedures exist. Homebrew publishes
-a formula that references the immutable upstream macOS archive and its
-upstream-verified SHA256; it does not repackage that binary.
+a formula for Apple Silicon that references the immutable upstream macOS
+archive and its upstream-verified SHA256; Intel macOS is unsupported, and the
+formula does not repackage that binary.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| GitHub Release assets, GHCR, npm, and the | |
| [`Mesh-LLM/tap`](https://github.com/Mesh-LLM/homebrew-tap) Homebrew tap are the | |
| enabled public channels. Do not create apt, apk, or pacman repositories until | |
| signing/trust-root ownership and rollback procedures exist. Homebrew publishes | |
| a formula that references the immutable upstream macOS archive and its | |
| upstream-verified SHA256; it does not repackage that binary. The tap polls this | |
| repository's latest non-prerelease packaging release, validates and installs | |
| the attached `mesh-llm.rb`, and commits it only when it changes. | |
| GitHub Release assets, GHCR, npm, and the | |
| [`Mesh-LLM/tap`](https://github.com/Mesh-LLM/homebrew-tap) Homebrew tap are the | |
| enabled public channels. Do not create apt, apk, or pacman repositories until | |
| signing/trust-root ownership and rollback procedures exist. Homebrew publishes | |
| a formula for Apple Silicon that references the immutable upstream macOS | |
| archive and its upstream-verified SHA256; Intel macOS is unsupported, and the | |
| formula does not repackage that binary. The tap polls this repository's latest | |
| non-prerelease packaging release, validates and installs the attached | |
| `mesh-llm.rb`, and commits it only when it changes. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/publishing.md` around lines 14 - 21, Update the Homebrew channel
description in the publishing documentation to state that the formula supports
Apple Silicon macOS only and that Intel macOS is unsupported. Keep the existing
immutable archive, verification, polling, and commit behavior unchanged.
Source: Coding guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mesh-LLM/tapas the canonical public Homebrew channel and its polling ownership contractValidation
node --experimental-strip-types --test tests/homebrew-release.test.tsactionlint -colorbrew audit --strict --online,brew install, andbrew teston Apple SiliconSummary by CodeRabbit
New Features
Documentation
Bug Fixes