Skip to content

Publish the Node SDK under the owned npm scope - #10

Merged
ndizazzo merged 2 commits into
mainfrom
codex/rename-node-sdk-npm-scope
Jul 28, 2026
Merged

Publish the Node SDK under the owned npm scope#10
ndizazzo merged 2 commits into
mainfrom
codex/rename-node-sdk-npm-scope

Conversation

@ndizazzo

@ndizazzo ndizazzo commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rename the canonical npm package to @mesh-llm/sdk, matching the existing npm organization
  • normalize only immutable v0.74.0 input from legacy @meshllm/sdk to the canonical package name
  • make the published repository metadata identify Mesh-LLM/mesh-packaging so npm OIDC can verify the publishing repository
  • remove NODE_AUTH_TOKEN and the NPM_TOKEN bootstrap fallback from the workflow and documentation
  • update matrix validation, package assembly validation, tests, smoke installation, inventory, and documentation

Root cause

The release contract targeted @meshllm/sdk, but the account owns @Mesh-LLM and meshllm is already taken. In addition, the assembled package metadata identified Mesh-LLM/mesh-llm while the GitHub Actions trusted publisher runs from Mesh-LLM/mesh-packaging. Both mismatches prevent a tokenless npm publication.

Immutable release handling

The v0.74.0 upstream tag cannot be changed and still declares @meshllm/sdk. The assembler accepts that legacy name only when the upstream version is exactly 0.74.0, rewrites the assembled tarball to @mesh-llm/sdk, and rejects the legacy name for every other version. Future source is corrected by Mesh-LLM/mesh-llm#1101.

Validation

  • node --experimental-strip-types scripts/image-matrix.ts validate
  • node --experimental-strip-types --test --experimental-test-coverage --test-coverage-lines=100 --test-coverage-branches=100 --test-coverage-functions=100 tests/image-matrix.test.ts
  • node --experimental-strip-types --test tests/node-sdk-package.test.ts
  • node --experimental-strip-types --test tests/*.test.ts
  • node --experimental-strip-types scripts/image-matrix.ts npm-plan --version 0.74.0
  • node --experimental-strip-types scripts/image-matrix.ts npm-matrix --version 0.74.0
  • actionlint .github/workflows/*.yml
  • Ruby YAML parse of all workflows
  • git diff --check

No production publication is triggered by this PR.

Summary by CodeRabbit

  • New Features

    • Standardized the Node SDK’s npm package name to @mesh-llm/sdk.
    • Updated package metadata and publishing configuration to use the canonical packaging repository.
    • Added support for migrating the legacy package name only from the approved bootstrap release.
  • Documentation

    • Updated release, packaging, publishing, and production-readiness guidance with the corrected package name and publishing requirements.
  • Bug Fixes

    • Improved package validation and release checks to reject incorrect package and repository metadata.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ndizazzo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f7d5e9e-76fe-41f4-96fd-dd9a2ffac9f5

📥 Commits

Reviewing files that changed from the base of the PR and between 6e140ad and e7af2c5.

📒 Files selected for processing (1)
  • docs/publishing.md
📝 Walkthrough

Walkthrough

The SDK package is renamed to @mesh-llm/sdk. Packaging metadata now targets the mesh-packaging repository, supports one immutable legacy bootstrap input, and release automation, configuration, tests, and documentation are updated accordingly.

Changes

Canonical npm package migration

Layer / File(s) Summary
Package metadata staging and validation
scripts/node-sdk-package.ts, tests/node-sdk-package.test.ts
Staging and validation now enforce canonical package and repository metadata, while accepting only the specified 0.74.0 legacy bootstrap package.
Release configuration and publish gates
packaging/images.json, scripts/image-matrix.ts, tests/image-matrix.test.ts, .github/workflows/images-release.yml
Npm configuration, consumer checks, expected plans, and publication checks now use @mesh-llm/sdk.
Published package documentation
README.md, TODO.md, docs/matrix.md, docs/publishing.md
Documentation references the canonical package and records trusted publishing and legacy-name handling requirements.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant assembleNodeSdk
  participant stagePackageMetadata
  participant packageJson
  participant validatePackageMetadata
  participant imagesRelease
  participant npmRegistry
  assembleNodeSdk->>stagePackageMetadata: stage upstream package metadata
  stagePackageMetadata->>packageJson: normalize canonical package metadata
  assembleNodeSdk->>validatePackageMetadata: validate staged metadata
  validatePackageMetadata-->>assembleNodeSdk: accept or reject metadata
  imagesRelease->>npmRegistry: check `@mesh-llm/sdk`@$RELEASE_VERSION
  npmRegistry-->>imagesRelease: publication status
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: moving the Node SDK to the owned npm scope.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/rename-node-sdk-npm-scope

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/publishing.md`:
- Around line 16-20: Clarify the publishing documentation’s environment
statement so `release` is explicitly limited to non-npm publish jobs, while
preserving that npm publishing uses the `npm` environment in the
`images-release.yml` workflow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b442afbc-7e18-476f-ac4c-8dc3899ef8ce

📥 Commits

Reviewing files that changed from the base of the PR and between 197b186 and 6e140ad.

📒 Files selected for processing (10)
  • .github/workflows/images-release.yml
  • README.md
  • TODO.md
  • docs/matrix.md
  • docs/publishing.md
  • packaging/images.json
  • scripts/image-matrix.ts
  • scripts/node-sdk-package.ts
  • tests/image-matrix.test.ts
  • tests/node-sdk-package.test.ts

Comment thread docs/publishing.md
@ndizazzo
ndizazzo merged commit 416a3e2 into main Jul 28, 2026
2 checks passed
@ndizazzo
ndizazzo deleted the codex/rename-node-sdk-npm-scope branch July 28, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant