Publish the Node SDK under the owned npm scope - #10
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe SDK package is renamed to ChangesCanonical npm package migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant assembleNodeSdk
participant stagePackageMetadata
participant packageJson
participant validatePackageMetadata
participant imagesRelease
participant npmRegistry
assembleNodeSdk->>stagePackageMetadata: stage upstream package metadata
stagePackageMetadata->>packageJson: normalize canonical package metadata
assembleNodeSdk->>validatePackageMetadata: validate staged metadata
validatePackageMetadata-->>assembleNodeSdk: accept or reject metadata
imagesRelease->>npmRegistry: check `@mesh-llm/sdk`@$RELEASE_VERSION
npmRegistry-->>imagesRelease: publication status
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/publishing.md`:
- Around line 16-20: Clarify the publishing documentation’s environment
statement so `release` is explicitly limited to non-npm publish jobs, while
preserving that npm publishing uses the `npm` environment in the
`images-release.yml` workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b442afbc-7e18-476f-ac4c-8dc3899ef8ce
📒 Files selected for processing (10)
.github/workflows/images-release.ymlREADME.mdTODO.mddocs/matrix.mddocs/publishing.mdpackaging/images.jsonscripts/image-matrix.tsscripts/node-sdk-package.tstests/image-matrix.test.tstests/node-sdk-package.test.ts
Summary
Root cause
The release contract targeted @meshllm/sdk, but the account owns @Mesh-LLM and meshllm is already taken. In addition, the assembled package metadata identified Mesh-LLM/mesh-llm while the GitHub Actions trusted publisher runs from Mesh-LLM/mesh-packaging. Both mismatches prevent a tokenless npm publication.
Immutable release handling
The v0.74.0 upstream tag cannot be changed and still declares @meshllm/sdk. The assembler accepts that legacy name only when the upstream version is exactly 0.74.0, rewrites the assembled tarball to @mesh-llm/sdk, and rejects the legacy name for every other version. Future source is corrected by Mesh-LLM/mesh-llm#1101.
Validation
No production publication is triggered by this PR.
Summary by CodeRabbit
New Features
@mesh-llm/sdk.Documentation
Bug Fixes