Fix release version staging - #996
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughRelease staging now uses ChangesRelease staging safeguards
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
Summary
scripts/release-version.shas the single owner of the complete version surfaceRoot cause
The
v0.73.1release workflow ranscripts/release-version.sh, which correctly updated Cargo, npm, Kotlin, docs, and version allowlists in the checkout. The tag-creation step then staged a hard-coded subset containing Cargo manifests,Cargo.lock, Kotlin metadata, andPackage.swift.That omitted
crates/mesh-llm-ui/package.json, its lockfile,sdk/node/package.json, and other tracked version-bearing files. The resulting tag contained Cargo version0.73.1but npm package version0.72.1. The crates.io preflight reran the shared updater and failed on that mismatch.Impact
Future release tags commit the complete tracked output from the shared version updater. Generated SDK console assets remain explicitly force-added.
This PR does not rewrite the already-published
v0.73.1tag. That tag needs deliberate recreation or replacement with a patch release after this change merges.Validation
bash -n scripts/release.sh scripts/release-version.shactionlint .github/workflows/release.ymlcargo fmt --all --checkcargo check -p xtaskcargo test -p xtaskcargo clippy -p xtask --all-targets -- -D warningscargo run -p xtask -- repo-consistency publish-cratesscripts/release-version.sh 0.72.2integration test confirming Cargo, both npm manifests, the UI lockfile, and Kotlin metadata all update, all 46 tracked changes stage, and a second run is idempotentSummary by CodeRabbit
Bug Fixes
Chores