Remove emulated response content logging - #954
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe emulated tool-call path in ChangesEmulated tool-call cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
What changed
Removed the unconditional stderr dump of completed model output from the server-side tool-call emulation parser.
Why
The debug statement emitted the entire generated response for every non-streaming emulated tool request. Model responses may contain private user data, tool results, credentials, or proprietary content, and stderr is commonly persisted by service managers.
Impact
Tool-call parsing and telemetry behavior are unchanged, but response content is no longer copied into process logs.
Validation
cargo test -p skippy-server --libSummary by CodeRabbit