Skip to content

Remove emulated response content logging - #954

Merged
i386 merged 1 commit into
mainfrom
jd/remove-emulated-response-logging
Jul 13, 2026
Merged

Remove emulated response content logging#954
i386 merged 1 commit into
mainfrom
jd/remove-emulated-response-logging

Conversation

@i386

@i386 i386 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What changed

Removed the unconditional stderr dump of completed model output from the server-side tool-call emulation parser.

Why

The debug statement emitted the entire generated response for every non-streaming emulated tool request. Model responses may contain private user data, tool results, credentials, or proprietary content, and stderr is commonly persisted by service managers.

Impact

Tool-call parsing and telemetry behavior are unchanged, but response content is no longer copied into process logs.

Validation

  • cargo test -p skippy-server --lib
  • 201 tests passed

Summary by CodeRabbit

  • Bug Fixes
    • Removed an unnecessary debug message that could appear when processing emulated tool-call responses.
    • Preserved existing tool-call parsing behavior for both complete and partial responses.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b1cf185e-d37a-413f-8a77-1c9a1fa25c0b

📥 Commits

Reviewing files that changed from the base of the PR and between 36a44b9 and c6899f2.

📒 Files selected for processing (1)
  • crates/skippy-server/src/frontend/prompting.rs
💤 Files with no reviewable changes (1)
  • crates/skippy-server/src/frontend/prompting.rs

📝 Walkthrough

Walkthrough

The emulated tool-call path in StageOpenAiBackend::parse_chat_output no longer emits a debug log containing raw non-partial model output. Its delegation to parse_emulated_chat_output remains unchanged.

Changes

Emulated tool-call cleanup

Layer / File(s) Summary
Remove raw output debug log
crates/skippy-server/src/frontend/prompting.rs
The emulation-only parsing branch removes the non-partial raw-output eprintln! while preserving the existing parsing call and return behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • Mesh-LLM/mesh-llm#946: Updates the same emulated tool-call parsing branch by removing the non-partial raw-output debug log.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing logging of emulated model response content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jd/remove-emulated-response-logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review.

@i386
i386 marked this pull request as ready for review July 10, 2026 22:30
@github-actions
github-actions Bot requested a review from ndizazzo July 10, 2026 22:30
@i386
i386 merged commit a55e81a into main Jul 13, 2026
43 of 45 checks passed
@i386
i386 deleted the jd/remove-emulated-response-logging branch July 13, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants