Skip to content

Update model card logo URL - #937

Merged
i386 merged 1 commit into
mainfrom
jd/update-model-card-logo
Jul 1, 2026
Merged

Update model card logo URL#937
i386 merged 1 commit into
mainfrom
jd/update-model-card-logo

Conversation

@i386

@i386 i386 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the model package README logo with the hosted Jelly wordmark asset.
  • Update the embedded-script unit test so it guards the new model card logo URL.

Why

Generated layer-package model cards still referenced the GitHub raw SVG logo. The generator should use https://meshllm.cloud/assets/images/jelly-logo-wordmark.png instead.

Validation

  • cargo test -p model-package embedded_script_writes_rich_model_card
  • cargo fmt --all --check
  • cargo check -p model-package
  • cargo clippy -p model-package --all-targets -- -D warnings

Summary by CodeRabbit

  • Documentation
    • Updated the model card branding image to use a new hosted logo asset.
    • The embedded job script’s rich model card now shows the updated Jelly/MeshLLM wordmark instead of the previous SVG logo.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a791450-2c7b-4850-9e91-28870e0c755f

📥 Commits

Reviewing files that changed from the base of the PR and between 7a80952 and 36ef2b7.

📒 Files selected for processing (2)
  • crates/model-package/src/script.rs
  • crates/model-package/src/scripts/split-model-job.sh

📝 Walkthrough

Walkthrough

The generated model card's header logo image source was changed from a GitHub-hosted SVG asset to a meshllm.cloud-hosted PNG asset. The corresponding test assertion in script.rs was updated to verify the new logo URL instead of the old one.

Changes

Model Card Logo Update

Layer / File(s) Summary
Logo asset swap and test update
crates/model-package/src/scripts/split-model-job.sh, crates/model-package/src/script.rs
The model card's header logo src changed from a GitHub-hosted SVG to a meshllm.cloud-hosted PNG (alt text and width unchanged), and the test assertion now checks for the new logo URL instead of the old asset path.

Estimated code review effort: 1 (Trivial) | ~3 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jd/update-model-card-logo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@i386
i386 marked this pull request as ready for review July 1, 2026 05:09
@github-actions
github-actions Bot requested a review from michaelneale July 1, 2026 05:09
@i386
i386 merged commit b4b33ef into main Jul 1, 2026
24 of 28 checks passed
@i386
i386 deleted the jd/update-model-card-logo branch July 1, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant