Skip to content

Validate package model IDs before submitting jobs - #891

Merged
i386 merged 1 commit into
jd/jianyang-model-package-mtpfrom
jd/package-model-id-validation
Jun 21, 2026
Merged

Validate package model IDs before submitting jobs#891
i386 merged 1 commit into
jd/jianyang-model-package-mtpfrom
jd/package-model-id-validation

Conversation

@i386

@i386 i386 commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Reject invalid explicit models package --model-id values while resolving the local package plan.
  • Make dry runs and confirmed submissions fail before queuing a Hugging Face Job when the model id is not a model coordinate.
  • Add focused tests for explicit valid ids, invalid short ids, and the default derived id path.

Context

While publishing the Gemma layer package from PR #888, job 6a37d21c3093dba73ce2b607 failed remotely because --model-id gemma-4-E4B-it-Q4_K_M passed local planning but was rejected by skippy-model-package write-package inside the paid HF job. This PR moves that validation into package preparation so the mistake is caught during --dry-run and before confirmed submission.

Validation

  • cargo fmt --all
  • cargo test -p model-package

Protocol

No mesh protocol or package format changes.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 88b5107a-1b14-434f-93e4-b70f0aedc1a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jd/package-model-id-validation

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot requested a review from ndizazzo June 21, 2026 12:11
@i386
i386 merged commit 554ede6 into jd/jianyang-model-package-mtp Jun 21, 2026
26 checks passed
@i386
i386 deleted the jd/package-model-id-validation branch June 21, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant