Add MTP anchored ngram speculation - #887
Closed
i386 wants to merge 4 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
i386
force-pushed
the
jd/jianyang-mtp-ngram
branch
from
June 21, 2026 04:24
5513c2a to
a413233
Compare
michaelneale
added a commit
that referenced
this pull request
Jul 22, 2026
Capture the draft-model speculative-decode pipelining findings for branch wip/wan-direct-prediction-return so the work can be picked up: what is proven over WAN, the draft-vs-ngram acceptance-survival result, a Cohere/SWA trim limitation, the 2-node bringup config trap, and pointers to the related ngram-widening PRs (#1037, #1026, #875, #887). Assisted-by: goose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a clean Skippy protocol break for mandatory client-open stage streams and implements server-native n-gram speculative proposals on the embedded stage-0 OpenAI path. The new path can use GLM native MTP as the first-token anchor and n-gram matching as a cheap span extender before distributed batched verification.
This PR is based on current
mainfrom a clean worktree. It does not include the discarded SPD/shard sidecar work.What changed
SOPNclient-open framing and bumps the stage state version to 7.--openai-ngram-speculative,--openai-ngram-size, and--openai-ngram-min-matchthroughserve-binary, embedded OpenAI args, and host-runtime Skippy resolution.native-mtp+ngramproposal path and telemetry labels for proposal source and MTP anchor verification.skippy-bench run --driver open-ai-chatpath that starts stage0 embedded OpenAI serving and drives/v1/chat/completions, so MTP+n-gram can be measured against the Improve GLM MTP parity and batched verify sampling #858 rows.Validation
Clean-main branch validation:
cargo fmt --all --checkcargo test -p skippy-protocol --libcargo test -p skippy-server --libcargo test -p skippy-benchcargo test -p skippy-correctnesscargo test -p skippy-promptcargo test -p mesh-llm-host-runtime --lib inference::skippycargo clippy -p skippy-protocol --all-targets -- -D warningscargo clippy -p skippy-server --all-targets -- -D warningscargo clippy -p skippy-bench --all-targets -- -D warningscargo clippy -p skippy-correctness --all-targets -- -D warningscargo clippy -p skippy-prompt --all-targets -- -D warningscargo clippy -p mesh-llm-host-runtime --all-targets -- -D warningscargo clippy -p mesh-llm --all-targets -- -D warningscargo check -p mesh-llmBenchmark path
The new benchmark row for this PR should be run with:
Run it against the same GLM 4.7 MTP split/model/prompt corpus used for #858. Generated-token tok/s in
driver-result.jsonis the hard metric; acceptance remains diagnostic telemetry.Notes
This PR intentionally breaks Skippy wire compatibility and removes the old optional compatibility path. Lab tok/s results still need to be collected on this branch before moving the PR out of draft.