Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions crates/skippy-topology/src/artifact_diagnostics.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
use crate::{DiagnosticSeverity, NodePlacementSignal, PlanDiagnostic, PlanReasonCode, StagePlan};

pub(crate) fn append_artifact_diagnostics(
diagnostics: &mut Vec<PlanDiagnostic>,
stages: &[StagePlan],
placement_signals: &[NodePlacementSignal],
) {
let cached_bytes = stages
.iter()
.map(|stage| stage.cached_slice_bytes)
.sum::<u64>();
let missing_bytes = stages
.iter()
.map(|stage| stage.missing_artifact_bytes)
.sum::<u64>();
Comment thread
i386 marked this conversation as resolved.
Resolved

if cached_bytes == 0 && missing_bytes == 0 {
return;
}

let peer_transfer_bytes = missing_bytes_by_transfer_support(stages, placement_signals, true);
let remote_download_bytes = missing_bytes.saturating_sub(peer_transfer_bytes);
let code = if missing_bytes > 0 {
PlanReasonCode::ArtifactTransferPenalty
} else {
PlanReasonCode::CacheLocalityPreferred
};

diagnostics.push(PlanDiagnostic {
severity: DiagnosticSeverity::Info,
code,
message: format!(
"artifact cold-start plan: cached={} bytes, missing={} bytes, peer-transfer-eligible={} bytes, remote-download-fallback={} bytes",
cached_bytes, missing_bytes, peer_transfer_bytes, remote_download_bytes
),
});
}

fn missing_bytes_by_transfer_support(
stages: &[StagePlan],
placement_signals: &[NodePlacementSignal],
transfer_supported: bool,
) -> u64 {
stages
.iter()
.filter(|stage| {
placement_signals
.iter()
.find(|signal| signal.node_id == stage.node_id)
.is_some_and(|signal| signal.artifact_transfer_supported == transfer_supported)
})
.map(|stage| stage.missing_artifact_bytes)
.sum()
}
5 changes: 5 additions & 0 deletions crates/skippy-topology/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
use serde::{Deserialize, Serialize};

mod artifact_diagnostics;

#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Serialize)]
pub struct TopologyPlanRequest {
pub topology_id: String,
Expand Down Expand Up @@ -1087,6 +1089,7 @@ fn plan_ranges_with_signals(
let diagnostics = diagnostics_for(
&stages,
&boundaries,
placement_signals,
request.family.as_ref(),
request.policy,
);
Expand Down Expand Up @@ -1375,10 +1378,12 @@ pub fn wire_payload_bytes_per_token(activation_width: u32, dtype: WireDType) ->
fn diagnostics_for(
stages: &[StagePlan],
boundaries: &[BoundaryPlan],
placement_signals: &[NodePlacementSignal],
family: Option<&FamilyCapabilityRecord>,
policy: PlannerPolicy,
) -> Vec<PlanDiagnostic> {
let mut diagnostics = Vec::new();
artifact_diagnostics::append_artifact_diagnostics(&mut diagnostics, stages, placement_signals);
for stage in stages {
if matches!(
stage.migration_policy,
Expand Down
64 changes: 64 additions & 0 deletions crates/skippy-topology/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,70 @@ fn package_aware_plan_prefers_cached_peer_for_equal_capacity() {
);
}

#[test]
fn package_aware_plan_reports_cold_start_artifact_totals() {
let mut transfer_ready = placement_signal("transfer-ready");
transfer_ready.missing_artifact_bytes = 32;
transfer_ready.artifact_transfer_supported = true;
let mut remote_fallback = placement_signal("remote-fallback");
remote_fallback.missing_artifact_bytes = 16;
remote_fallback.artifact_transfer_supported = false;
let mut warm = placement_signal("warm");
warm.cached_slice_bytes = 64;
let request = TopologyPlanRequest {
topology_id: "topology-a".into(),
model_id: "model-a".into(),
layers: dense_attention_layers(9, 10),
nodes: vec![
weighted_node("transfer-ready", 30),
weighted_node("remote-fallback", 30),
weighted_node("warm", 30),
],
family: None,
policy: PlannerPolicy::default(),
};

let plan = plan_package_aware_contiguous_with_signals(
&request,
&[transfer_ready, remote_fallback, warm],
)
.expect("plan");

let diagnostic = plan
.diagnostics
.iter()
.find(|diagnostic| diagnostic.code == PlanReasonCode::ArtifactTransferPenalty)
.expect("artifact diagnostic");
assert!(diagnostic.message.contains("cached=64 bytes"));
assert!(diagnostic.message.contains("missing=48 bytes"));
assert!(
diagnostic
.message
.contains("peer-transfer-eligible=32 bytes")
);
assert!(
diagnostic
.message
.contains("remote-download-fallback=16 bytes")
);
}

#[test]
fn weighted_plan_without_artifact_signals_stays_diagnostic_quiet() {
let request = TopologyPlanRequest {
topology_id: "topology-a".into(),
model_id: "model-a".into(),
layers: dense_attention_layers(6, 10),
nodes: vec![weighted_node("node-a", 30), weighted_node("node-b", 30)],
family: None,
policy: PlannerPolicy::default(),
};

let plan = plan_weighted_contiguous(&request).expect("plan");

assert!(plan.diagnostics.is_empty());
}

#[test]
fn package_aware_plan_penalizes_missing_untransferable_artifacts() {
let mut cold = placement_signal("cold-high-vram");
Expand Down
Loading