fix(release): patch Package.swift manifest with xcframework artifact metadata - #667
Closed
keranm wants to merge 4 commits into
Closed
fix(release): patch Package.swift manifest with xcframework artifact metadata#667keranm wants to merge 4 commits into
keranm wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release pipeline builds and uploads
MeshLLMFFI.xcframework.zipcorrectly via
build_swift_sdk_artifact, but never substitutes the__MESH_SWIFT_RELEASE_TAG__and__MESH_SWIFT_RELEASE_CHECKSUM__placeholders in
Package.swift. This means SPM consumers alwaysresolve placeholder tokens and cannot use the binary target, even
when the zip is attached to the release.
Changes
Adds a
patch_swift_package_manifestjob that runs afterbuild_swift_sdk_artifact:Package.swiftwith the real release download URL and checksumThe
publishjob now depends onpatch_swift_package_manifest,ensuring
Package.swiftis correct before the GitHub Release is created.Context
Follows on from #665 (versioned macOS bundle layout fix) and #666
(native xcodebuild assembly). Without this change, the xcframework
zip is present in releases but unreachable via SPM.
Tested: xcframework built locally from this branch against an
external Swift client — binary target resolves correctly.