Skip to content

[codex] Restore chat tool-call ID normalization - #658

Merged
i386 merged 1 commit into
jd/sdkfrom
codex/fix-sdk-tool-call-ids
May 23, 2026
Merged

[codex] Restore chat tool-call ID normalization#658
i386 merged 1 commit into
jd/sdkfrom
codex/fix-sdk-tool-call-ids

Conversation

@i386

@i386 i386 commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Restores OpenAI chat tool-call ID normalization on the SDK branch so non-stream /v1/chat/completions responses synthesize missing tool_calls[].id values before clients see them.

Root Cause

The SDK branch dropped the non-stream chat-completion response adapter while retaining the stream adapter. The nightly stability harness then failed the auto non-stream tool-call probe with tool call is missing an id.

Impact

Agent clients using non-stream chat completions can reliably continue after tool calls again, matching the behavior already present on main and the streaming response path.

Validation

  • cargo test -p mesh-llm-host-runtime chat_completion_json_normalizer --lib
  • cargo test -p mesh-llm-host-runtime relay_normalized_chat_completion_json_adds_missing_tool_call_id --lib
  • cargo test -p mesh-llm-host-runtime chat_stream_normalizer --lib
  • cargo check -p mesh-llm
  • cargo fmt --all -- --check

Full cargo test -p mesh-llm-host-runtime --lib was also run; it failed on two unrelated existing network::nostr::auto_pack_tests display-name expectations.

@i386
i386 marked this pull request as ready for review May 23, 2026 19:41
@i386
i386 merged commit 899d679 into jd/sdk May 23, 2026
20 checks passed
@i386
i386 deleted the codex/fix-sdk-tool-call-ids branch May 23, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant