ci: fail fast on topic lane projections

[ndizazzo]

Summary

• fix the quality and website jq projections so they emit valid JSON
• evaluate those projections before writing action outputs so jq failures stop planning
• execute the exact projection programs in regression coverage

Activation evidence

Temporary PR #1273 exposed this on protected controller run 31656893304: both topic projections failed jq compilation inside command substitutions, leaving empty outputs while the planner step reported success.

Validation

• python3 -m unittest scripts.tests.test_ci_lane_workflows
• just ci-validate (413 tests, 7 skipped)

Summary by CodeRabbit

• Bug Fixes

  • Improved validation and generation of automated quality and website check plans.
  • Ensured lane-specific requirements, signals, budgets, and matrices are preserved consistently in CI results.

• Tests

  • Added coverage to verify that generated quality and website plans are valid and contain the expected lane and requirement details.

[coderabbitai]

Warning

Review limit reached

@ndizazzo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 790950d9-a33d-49f1-af51-c75311ff3971

📥 Commits

Reviewing files that changed from the base of the PR and between e971618 and fc840a6.

📒 Files selected for processing (1)

• scripts/tests/test_ci_lane_workflows.py

📝 Walkthrough

Walkthrough

The CI action now precomputes quality and website lane-plan JSON with validated jq expressions. GitHub outputs use these values. Tests execute both projections and verify their lane and required fields.

Changes

CI lane-plan projections

Layer / File(s)	Summary
Build and emit lane plans .github/actions/plan-ci/action.yml	The action builds quality and website lane plans with lane-specific conditions and matrices, then emits the precomputed JSON outputs.
Validate jq projections scripts/tests/test_ci_lane_workflows.py	Tests extract and execute both jq projections and verify the expected lane and required status.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to e9716

The PR makes CI projection failures stop planning instead of producing empty outputs; the remaining concern is a bounded test-coverage improvement, and no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

• Mesh-LLM/mesh-llm#1244: Introduced the action and test files updated by this pull request.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: making CI topic lane projections fail fast.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-ci-lane-projections

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/tests/test_ci_lane_workflows.py`:
- Around line 141-174: Extend test_topic_lane_projections_are_valid_jq with a
fixture lacking each lane-specific slice to exercise required == false, while
preserving the existing true-case coverage. For both fixtures, assert the
downstream projection contract for required_slices, signals, budgets, and
matrices.clippy, using the expected values from the input plan and lane
projection.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 23e41ef3-b985-42ab-88ba-61d5988bd772

📥 Commits

Reviewing files that changed from the base of the PR and between 99cd8ee and e971618.

📒 Files selected for processing (2)

• .github/actions/plan-ci/action.yml
• scripts/tests/test_ci_lane_workflows.py