Skip to content

ci: distinguish skipped bootstrap routes - #1272

Merged
ndizazzo merged 1 commit into
mainfrom
codex/ci-lane-activation-test
Aug 13, 2026
Merged

ci: distinguish skipped bootstrap routes#1272
ndizazzo merged 1 commit into
mainfrom
codex/ci-lane-activation-test

Conversation

@ndizazzo

@ndizazzo ndizazzo commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Problem

The first post-#1244 activation probe showed that GitHub includes the unselected bootstrap caller in the entry run's job list with conclusion=skipped. The protected controller matched the bootstrap job name without checking its conclusion, so it suppressed lane dispatch for every thin PR/main route.

Fix

Treat exact and reusable-workflow-prefixed bootstrap job names as evidence only when the matching job was not skipped. Actual bootstrap executions still suppress protected redispatch; an unselected bootstrap caller no longer does.

Validation

  • just ci-validate
  • 412 Python tests passed (7 expected skips)
  • actionlint and repository-consistency checks passed

This prerequisite must merge before the temporary split-lane activation probe. Depot remains trusted-main only; no provider, variable, runner-group, or cache setting changes are included.

Summary by CodeRabbit

  • Bug Fixes

    • Improved workflow dispatch decisions by ignoring bootstrap jobs that were skipped.
    • Dispatch is now suppressed only when a matching bootstrap job completed without being skipped.
  • Tests

    • Added coverage to verify skipped bootstrap jobs do not block dispatch.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6497414e-93b4-4ea0-967d-43c6c73637f0

📥 Commits

Reviewing files that changed from the base of the PR and between d777b0c and fc95251.

📒 Files selected for processing (2)
  • .github/workflows/ci-control.yml
  • scripts/tests/test_ci_lane_workflows.py

📝 Walkthrough

Walkthrough

The controller workflow now ignores matching bootstrap jobs with a skipped conclusion. The workflow test verifies the non-skipped conclusion condition.

Changes

Bootstrap dispatch control

Layer / File(s) Summary
Exclude skipped bootstrap jobs
.github/workflows/ci-control.yml, scripts/tests/test_ci_lane_workflows.py
Bootstrap detection requires matching jobs to have a conclusion other than skipped. The test asserts this condition.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to fc952

The current changes present no actionable merge-blocking risk based on the supplied evidence; normal checks and review remain sufficient.

Suggested reviewers: i386

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: excluding skipped bootstrap routes from dispatch suppression decisions.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ci-lane-activation-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ndizazzo
ndizazzo force-pushed the codex/ci-lane-activation-test branch from d777b0c to fc95251 Compare August 13, 2026 01:05
@ndizazzo ndizazzo changed the title ci: verify protected split-lane activation ci: distinguish skipped bootstrap routes Aug 13, 2026
@ndizazzo
ndizazzo merged commit 99cd8ee into main Aug 13, 2026
59 checks passed
@ndizazzo
ndizazzo deleted the codex/ci-lane-activation-test branch August 13, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant