ci: distinguish skipped bootstrap routes - #1272
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe controller workflow now ignores matching bootstrap jobs with a ChangesBootstrap dispatch control
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to The current changes present no actionable merge-blocking risk based on the supplied evidence; normal checks and review remain sufficient. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d777b0c to
fc95251
Compare
Problem
The first post-#1244 activation probe showed that GitHub includes the unselected bootstrap caller in the entry run's job list with
conclusion=skipped. The protected controller matched the bootstrap job name without checking its conclusion, so it suppressed lane dispatch for every thin PR/main route.Fix
Treat exact and reusable-workflow-prefixed bootstrap job names as evidence only when the matching job was not skipped. Actual bootstrap executions still suppress protected redispatch; an unselected bootstrap caller no longer does.
Validation
just ci-validateThis prerequisite must merge before the temporary split-lane activation probe. Depot remains trusted-main only; no provider, variable, runner-group, or cache setting changes are included.
Summary by CodeRabbit
Bug Fixes
Tests