Skip to content

Fix split GGUF stage inventory discovery - #1199

Merged
i386 merged 1 commit into
Mesh-LLM:jd/split-skippy-modulesfrom
i386:codex/issue-1186-stage-inventory
Aug 8, 2026
Merged

Fix split GGUF stage inventory discovery#1199
i386 merged 1 commit into
Mesh-LLM:jd/split-skippy-modulesfrom
i386:codex/issue-1186-stage-inventory

Conversation

@i386

@i386 i386 commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes direct split-GGUF stage inventory discovery for models whose first shard is metadata-only, stacked on #1194.

Root cause

Stage inventory discovery inferred the layer count only by scanning tensor names. DeepSeek-V4 split GGUFs can place metadata in the first shard while storing all tensors in later shards, so the tensor scan returned no layers and the peer advertised an empty inventory. Split readiness then waited indefinitely even though the mesh connection itself was healthy.

Fix

  • Reuse direct-GGUF shard expansion to validate and enumerate every shard.
  • Read the layer count from compact GGUF metadata first, retaining tensor inspection as a fallback.
  • Compute the advertised source size across all validated shards.
  • Add a regression test for a metadata-only first shard.

Validation

  • just build
  • cargo test -p mesh-llm-host-runtime --lib inventory_source_resolves_metadata_only_first_shard
  • cargo fmt --all --check
  • cargo check -p mesh-llm-host-runtime
  • cargo check -p mesh-llm
  • cargo clippy -p mesh-llm-host-runtime --all-targets -- -D warnings -A unfulfilled-lint-expectations
  • cargo clippy -p mesh-llm --all-targets -- -D warnings -A unfulfilled-lint-expectations

Strict clippy remains blocked by 28 pre-existing unfulfilled_lint_expectations errors in the parent PR branch; none are in this diff.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a3348be-3e5f-4144-be93-eb27f06fe455

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@i386
i386 marked this pull request as ready for review August 8, 2026 18:33
@github-actions
github-actions Bot requested a review from michaelneale August 8, 2026 18:33
@i386
i386 merged commit edab600 into Mesh-LLM:jd/split-skippy-modules Aug 8, 2026
66 of 84 checks passed
@i386
i386 deleted the codex/issue-1186-stage-inventory branch August 8, 2026 23:21
i386 added a commit that referenced this pull request Aug 9, 2026
i386 added a commit that referenced this pull request Aug 10, 2026
* Split Skippy by functional boundary

* Rebuild llama patch queue by functional boundary

* Add explicit standard library includes to Skippy modules

* Add explicit tokenization limit dependency

* Address Skippy queue review findings

* Advertise Skippy chat feature support

* Fix split GGUF stage inventory discovery (#1199)

* feat: pass reasoning effort through Skippy templates

* feat: advertise reasoning efforts in model listings

* docs: require Skippy ABI inventories in PRs

* docs: clarify Skippy ABI lockstep policy

* refactor: remove legacy Skippy chat ABI

* fix: stop advertising reasoning effort values

* fix: preserve Skippy no-thinking override

* docs: publish Skippy native API reference

* fix: address Skippy API doc review comments

* Split Skippy by functional boundary

* Rebuild llama patch queue by functional boundary

* Add explicit standard library includes to Skippy modules

* Add explicit tokenization limit dependency

* Address Skippy queue review findings

* Advertise Skippy chat feature support

* Fix split GGUF stage inventory discovery (#1199)

* feat: pass reasoning effort through Skippy templates

* feat: advertise reasoning efforts in model listings

* docs: require Skippy ABI inventories in PRs

* docs: clarify Skippy ABI lockstep policy

* refactor: remove legacy Skippy chat ABI

* fix: stop advertising reasoning effort values

* fix: preserve Skippy no-thinking override
i386 added a commit that referenced this pull request Aug 10, 2026
* Split Skippy by functional boundary

* Rebuild llama patch queue by functional boundary

* Add explicit standard library includes to Skippy modules

* Add explicit tokenization limit dependency

* Address Skippy queue review findings

* Advertise Skippy chat feature support

* Fix split GGUF stage inventory discovery (#1199)
i386 added a commit that referenced this pull request Aug 10, 2026
* Split Skippy by functional boundary

* Rebuild llama patch queue by functional boundary

* Add explicit standard library includes to Skippy modules

* Add explicit tokenization limit dependency

* Address Skippy queue review findings

* Advertise Skippy chat feature support

* Fix split GGUF stage inventory discovery (#1199)

* feat: pass reasoning effort through Skippy templates

* feat: advertise reasoning efforts in model listings

* docs: require Skippy ABI inventories in PRs

* docs: clarify Skippy ABI lockstep policy

* refactor: remove legacy Skippy chat ABI

* fix: stop advertising reasoning effort values

* fix: preserve Skippy no-thinking override

* docs: publish Skippy native API reference

* fix: address Skippy API doc review comments

* Split Skippy by functional boundary

* Rebuild llama patch queue by functional boundary

* Add explicit standard library includes to Skippy modules

* Add explicit tokenization limit dependency

* Address Skippy queue review findings

* Advertise Skippy chat feature support

* Fix split GGUF stage inventory discovery (#1199)

* feat: pass reasoning effort through Skippy templates

* feat: advertise reasoning efforts in model listings

* docs: require Skippy ABI inventories in PRs

* docs: clarify Skippy ABI lockstep policy

* refactor: remove legacy Skippy chat ABI

* fix: stop advertising reasoning effort values

* fix: preserve Skippy no-thinking override
i386 added a commit that referenced this pull request Aug 10, 2026
* feat: pass reasoning effort through Skippy templates

* feat: advertise reasoning efforts in model listings

* docs: require Skippy ABI inventories in PRs

* docs: clarify Skippy ABI lockstep policy

* refactor: remove legacy Skippy chat ABI

* fix: stop advertising reasoning effort values

* fix: preserve Skippy no-thinking override

* docs: publish Skippy native API reference (#1217)

* Split Skippy by functional boundary

* Rebuild llama patch queue by functional boundary

* Add explicit standard library includes to Skippy modules

* Add explicit tokenization limit dependency

* Address Skippy queue review findings

* Advertise Skippy chat feature support

* Fix split GGUF stage inventory discovery (#1199)

* feat: pass reasoning effort through Skippy templates

* feat: advertise reasoning efforts in model listings

* docs: require Skippy ABI inventories in PRs

* docs: clarify Skippy ABI lockstep policy

* refactor: remove legacy Skippy chat ABI

* fix: stop advertising reasoning effort values

* fix: preserve Skippy no-thinking override

* docs: publish Skippy native API reference

* fix: address Skippy API doc review comments

* Split Skippy by functional boundary

* Rebuild llama patch queue by functional boundary

* Add explicit standard library includes to Skippy modules

* Add explicit tokenization limit dependency

* Address Skippy queue review findings

* Advertise Skippy chat feature support

* Fix split GGUF stage inventory discovery (#1199)

* feat: pass reasoning effort through Skippy templates

* feat: advertise reasoning efforts in model listings

* docs: require Skippy ABI inventories in PRs

* docs: clarify Skippy ABI lockstep policy

* refactor: remove legacy Skippy chat ABI

* fix: stop advertising reasoning effort values

* fix: preserve Skippy no-thinking override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants