Use native Depot registry auth for canary - #1158
Conversation
📝 WalkthroughWalkthroughThe registry canary now uses pre-authenticated ChangesDepot Registry authentication
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/tests/test_depot_registry_canary_workflow.py (1)
19-37: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winScope the authentication assertions to
jobs.pull.The assertions search the entire workflow text. They can pass if the Depot runner or
DEPOT_ORG_IDguard moves topolicywhilepulluses a hosted runner. Thecount()check has the same gap and does not prove that the guard runs beforedocker pull. Parse the workflow or isolatejobs.pullbefore checking its runner and guard. Keep token-removal assertions global.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/tests/test_depot_registry_canary_workflow.py` around lines 19 - 37, The tests test_registry_auth_is_native_and_job_scoped and test_canary_uses_fresh_runner_samples_and_exact_digest must isolate or parse jobs.pull before asserting its Depot runner, DEPOT_ORG_ID guard, authentication message, and ordering before docker pull. Keep token-removal assertions global, while ensuring the runner count and pull-job checks cannot pass based on the policy job.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@scripts/tests/test_depot_registry_canary_workflow.py`:
- Around line 19-37: The tests test_registry_auth_is_native_and_job_scoped and
test_canary_uses_fresh_runner_samples_and_exact_digest must isolate or parse
jobs.pull before asserting its Depot runner, DEPOT_ORG_ID guard, authentication
message, and ordering before docker pull. Keep token-removal assertions global,
while ensuring the runner count and pull-job checks cannot pass based on the
policy job.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4e7a34b0-d85c-4881-bcae-5a44603abf48
📒 Files selected for processing (5)
.github/workflows/depot-registry-canary.ymlci/DEPOT_MIGRATION.mdci/METRICS.mdci/ci.mdscripts/tests/test_depot_registry_canary_workflow.py
Summary
Validation
Summary by CodeRabbit
CI Improvements
Documentation
Tests