fix: keep Windows release verifier native-ABI-free - #1114
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (19)
📝 WalkthroughWalkthroughThe pull request introduces ChangesRelease Footer Integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge validation: the critical |
Summary
mesh-llm-release-footercratextaskdepend directly on that crate instead ofmesh-llm-systemmesh_llm_system::embedded_release_footeras a compatibility re-exportWhy
The fresh
v0.75.0-rc1release run built the immutable Windows host successfully, then failed while building the attestation verifier.xtaskdepended onmesh-llm-system, which transitively pulledmesh-llm-runtime-install -> skippy-ffiand attempted to build the native llama.cpp ABI in the host-only lane.The Windows-target
xtaskdependency graph now contains none ofmesh-llm-system,mesh-llm-runtime-install,skippy-ffi, orskippy-runtime.Validation
actionlintcargo fmt --all --checkmesh-llm-release-footertestsxtasktestscargo checkand Clippy with warnings denied formesh-llm-release-footer,xtask,mesh-llm-system, andmesh-llmcargo publish --locked -p mesh-llm-release-footer --dry-run --allow-dirtyThis is the focused release unblock extracted from the broader composable CI work in #1113.
Summary by CodeRabbit
New Features
Documentation
Build & Infrastructure