fix: use published mesh-llm-hf-hub crate - #1096
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe workspace removes the custom ChangesHugging Face Hub migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
|
CI diagnosis: the dependency switch is resolving the real crates.io package correctly, and it exposed that |
* origin/main: fix: use published mesh-llm-hf-hub crate (#1096)
Summary
mesh-llm-hf-hubcrates.io package.[patch.crates-io]Git override.model-packageto borrowrepo_id, matching the published fork API.This addresses the dependency-resolution gap in #1094: the workspace and crates.io package verification now compile against the same published fork instead of silently resolving
hf-hubupstream outside the workspace.@michaelneale — please review the fork/package dependency decision and the compatibility fix.
Validation
cargo check -p model-hf -p model-package -p mesh-llm-commands -p mesh-llm-host-runtimecargo clippy -p model-package --all-targets -- -D warningscargo fmt -p model-package -- crates/model-package/src/bin/queue-unsloth-layer-packages.rsThe registry-backed check initially reproduced the
repo_id(String)failure from #1094; after the borrow fix it passes.Summary by CodeRabbit