Skip to content

fix: use published mesh-llm-hf-hub crate - #1096

Merged
i386 merged 2 commits into
mainfrom
jd/mesh-llm-hf-hub
Jul 28, 2026
Merged

fix: use published mesh-llm-hf-hub crate#1096
i386 merged 2 commits into
mainfrom
jd/mesh-llm-hf-hub

Conversation

@i386

@i386 i386 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Switch all published hf-hub consumers to the mesh-llm-hf-hub crates.io package.
  • Remove the workspace-only [patch.crates-io] Git override.
  • Fix model-package to borrow repo_id, matching the published fork API.

This addresses the dependency-resolution gap in #1094: the workspace and crates.io package verification now compile against the same published fork instead of silently resolving hf-hub upstream outside the workspace.

@michaelneale — please review the fork/package dependency decision and the compatibility fix.

Validation

  • cargo check -p model-hf -p model-package -p mesh-llm-commands -p mesh-llm-host-runtime
  • cargo clippy -p model-package --all-targets -- -D warnings
  • cargo fmt -p model-package -- crates/model-package/src/bin/queue-unsloth-layer-packages.rs

The registry-backed check initially reproduced the repo_id(String) failure from #1094; after the borrow fix it passes.

Summary by CodeRabbit

  • Chores
    • Updated model, host runtime, and command components to use the standard Hugging Face Hub integration (newer HF Hub library version).
    • Removed a custom workspace override so dependency resolution follows the default crates registry behavior.
  • Bug Fixes
    • Improved queued package upload marker behavior by avoiding unnecessary string cloning when generating the Hugging Face repository identifier.

@i386
i386 requested a review from michaelneale July 28, 2026 03:23
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 447f9bd4-0cc8-4dfe-9ec7-abe5f3e5052f

📥 Commits

Reviewing files that changed from the base of the PR and between 7e1737d and 9277583.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • crates/mesh-llm-commands/Cargo.toml
  • crates/mesh-llm-host-runtime/Cargo.toml
  • crates/model-hf/Cargo.toml
  • crates/model-package/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (2)
  • crates/model-package/Cargo.toml
  • crates/mesh-llm-host-runtime/Cargo.toml

📝 Walkthrough

Walkthrough

The workspace removes the custom hf-hub patch, updates four crates to mesh-llm-hf-hub version 1.0.2, and changes queue marker repository creation to borrow the target repository identifier.

Changes

Hugging Face Hub migration

Layer / File(s) Summary
Update dependency sources
Cargo.toml, crates/*/Cargo.toml
Removes the workspace hf-hub patch and switches four crate dependencies to mesh-llm-hf-hub 1.0.2 while preserving the blocking feature configuration.
Adjust repository identifier argument
crates/model-package/src/bin/queue-unsloth-layer-packages.rs
Passes candidate.target_repo by reference to repo_id(...) instead of cloning it.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

  • Issue 1094 — Covers replacing the patched dependency with the published mesh-llm-hf-hub crate and updating the affected repo_id call.

Possibly related PRs

  • Mesh-LLM/mesh-llm#1093 — Contains the matching write_queue_marker borrow change for the hf-hub API update.

Suggested reviewers: michaelneale, ndizazzo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: switching consumers to the published mesh-llm-hf-hub crate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jd/mesh-llm-hf-hub

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review.

@i386
i386 marked this pull request as ready for review July 28, 2026 03:23
@github-actions
github-actions Bot requested a review from ndizazzo July 28, 2026 03:23
@i386

i386 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

CI diagnosis: the dependency switch is resolving the real crates.io package correctly, and it exposed that mesh-llm-hf-hub@1.0.0 does not contain the fork’s resumable-download implementation. The failing check is model_hf::tests::download_file_resumes_existing_incomplete_cache_blob, which receives no Range request. The next fix is to publish a patched mesh-llm-hf-hub release (for example 1.0.1) from the resumable fork line, then retarget this PR; the regression test should remain enabled.

@michaelneale

@i386
i386 merged commit a878919 into main Jul 28, 2026
33 checks passed
@i386
i386 deleted the jd/mesh-llm-hf-hub branch July 28, 2026 06:14
michaelneale added a commit that referenced this pull request Jul 28, 2026
* origin/main:
  fix: use published mesh-llm-hf-hub crate (#1096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants