chore: make the Node SDK installable from npm releases - #1092
Conversation
📝 WalkthroughWalkthroughThe release workflow now requests npm publication from ChangesNode SDK npm release
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@sdk/node/package.json`:
- Around line 7-10: Update the repository metadata in sdk/node/package.json to
use the mesh-llm source repository instead of mesh-packaging, and add the
repository directory field set to "sdk/node". Leave the existing repository type
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 96daf45a-9151-4ba5-ab5e-9a4b1d79179b
📒 Files selected for processing (10)
.agents/skills/manage-ci/references/current-inventory.md.github/workflows/release.ymlRELEASE.mdci/ci.mddocs/SDK.mddocs/sdk/node.mdsdk/node/README.mdsdk/node/package.jsonsdk/node/scripts/build-native.mjswebsite/src/docs/pages/sdk-node.md
|
Nice reviewing now |
i386
left a comment
There was a problem hiding this comment.
I found one release-ordering risk to resolve before merging: the downstream Mesh-LLM/mesh-packaging main workflow currently ignores client_payload.publish_npm; that support is only in packaging PR #5. If this PR lands first, the next release will dispatch successfully but silently omit npm publication. Please merge/deploy the packaging workflow change first (or otherwise gate/coordinate this flag) so the source and consumer workflows become active together.
| publish_images: true, | ||
| publish_release_assets: true | ||
| publish_release_assets: true, | ||
| publish_npm: true |
There was a problem hiding this comment.
Ignore this comment. The concern is addressed once Mesh-LLM/mesh-packaging#5 is merged, because that workflow then consumes client_payload.publish_npm.
|
I was not relishing this work. Thank you for doing it. |
Summary
Node.js and Electron users can install
@meshllm/sdkwithnpm install @meshllm/sdkonce the canonical packaging workflow publishes the next release.This is the source-side handoff for Mesh-LLM/mesh-packaging#5 and supersedes #1062. Cross-platform build, assembly, preflight, and publication orchestration now live in
mesh-packaging.Architecture
mesh-llmremains the SDK source repository. The package repository metadata namesMesh-LLM/mesh-packagingbecause npm trusted publishing requires it to match the workflow that runsnpm publish; homepage and issue links continue to point to this repository.Validation
actionlint -config-file .github/actionlint.yamlpassedcargo run -p xtask -- repo-consistency release-targetspassedgit diff --checkpassednpm publish --dry-run, installed it in a clean consumer, and loaded the real macOS arm64 addoncc @ndizazzo
Summary by CodeRabbit
New Features
Documentation
npm install@meshllm/sdk``.