fix(console-ui): chat transcript snapping during live status updates - #1083
Merged
ndizazzo merged 2 commits intoJul 26, 2026
Merged
Conversation
Contributor
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
📝 WalkthroughWalkthroughChatLayout now preserves manual transcript positions unless the reader is near the bottom. ChatPageContent resets bottom-sticking when conversations change or new and retried turns begin, with expanded tests covering these scroll flows. ChangesChat transcript scrolling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ChatPageContent
participant ChatLayout
participant MessageList
ChatPageContent->>ChatLayout: pass stickToBottomKey
MessageList->>ChatLayout: report scroll position
ChatLayout->>MessageList: scroll to latest when enabled
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bradleydwyer
marked this pull request as ready for review
July 26, 2026 05:03
Collaborator
|
Thanks for the fix @bradleydwyer! |
michaelneale
added a commit
that referenced
this pull request
Jul 27, 2026
* origin/main: Fix Metal small-batch matmul parity for GLM verification (#1078) Handle K-only transposed KV page import and export (#1084) Refresh llama.cpp upstream patch queue (#1085) chore: improve embedded native-runtime compatibility guidance (#1043) fix(console-ui): chat transcript snapping during live status updates (#1083) ci: bump Linux CUDA slim container to gha-convention base runner image fix: record activation cache prefix identities (#1041) fix: read-only model download caches (#1042) ci: disable sccache for Windows ROCm native runtime build (#1087) ci: fix v0.74 release GPU builds (sccache disk-only + force_hosted_runners) (#1086) Make release sccache failures non-fatal (#1079) Keep client-only nodes out of model election (#1074) # Conflicts: # crates/mesh-llm-host-runtime/src/runtime/auto_join.rs # crates/mesh-llm-host-runtime/src/runtime/tests/auto_join.rs # third_party/llama.cpp/patches/0004-Add-lanes-external-media-and-chat-grammar-support.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1077.
Original problem
In live mode, frequent status updates rerendered
ChatLayout, whose layout effect unconditionally returned the transcript to the latest message. Readers scrolling through a long response were repeatedly snapped back to the bottom.Diagnostics
The live status stream produced 49 payloads in 12 seconds. Each payload updated the status query, rerendered the chat layout, and ran the unconditional scroll effect. Safari applied the user's scroll normally before the next React render overwrote the position.
Fix
This is a UI-only behavior change with no protocol, storage, or migration impact.
Summary by CodeRabbit
New Features
Bug Fixes