Add GLM MoE Metal active expert patches - #1035
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
204a0e1 to
5d8b55f
Compare
michaelneale
left a comment
There was a problem hiding this comment.
Approving. Clean stacked patch layer on top of the GLM-DSA foundation — all 12 files are llama.cpp patch files with no Rust/protocol/ABI surface of its own, so zero collision risk with in-flight work. Good stacking discipline keeping the MoE Metal perf work separate from the core foundation.
Note this is gated on its base (#1034, jd/glm-dsa-llama-foundation) merging first — it can't land until then.
60ec824 to
e40ac0d
Compare
e7fc73e to
6af4462
Compare
e40ac0d to
f4c41ce
Compare
Summary
Why
This keeps the GLM MoE performance work separate from the core GLM-DSA architecture and IndexShare support. The branch is stacked so the foundation can be reviewed first, then the active-expert Metal path can be reviewed as the next layer.
Validation