Skip to content

Add GLM MoE Metal active expert patches - #1035

Closed
i386 wants to merge 1 commit into
jd/glm-dsa-llama-foundationfrom
jd/glm-moe-metal-active
Closed

Add GLM MoE Metal active expert patches#1035
i386 wants to merge 1 commit into
jd/glm-dsa-llama-foundationfrom
jd/glm-moe-metal-active

Conversation

@i386

@i386 i386 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a stacked GLM MoE Metal patch queue on top of the GLM-DSA llama foundation branch
  • add active-expert Q3 down kernels and Q2 gate/up dispatch controls for GLM-5.2 style expert tensors
  • add selector diagnostics and focused backend/perf tests for selected expert paths

Why

This keeps the GLM MoE performance work separate from the core GLM-DSA architecture and IndexShare support. The branch is stacked so the foundation can be reviewed first, then the active-expert Metal path can be reviewed as the next layer.

Validation

  • LLAMA_WORKDIR=/tmp/mesh-llm-llama-moe.bjcGOo scripts/prepare-llama.sh pinned
  • just build

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c7dfda5-2edb-42d7-9a4b-9b1f580a24af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jd/glm-moe-metal-active

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review.

@i386
i386 force-pushed the jd/glm-moe-metal-active branch from 204a0e1 to 5d8b55f Compare July 21, 2026 05:34
@i386
i386 marked this pull request as ready for review July 21, 2026 05:47
@github-actions
github-actions Bot requested a review from ndizazzo July 21, 2026 05:48

@michaelneale michaelneale left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Clean stacked patch layer on top of the GLM-DSA foundation — all 12 files are llama.cpp patch files with no Rust/protocol/ABI surface of its own, so zero collision risk with in-flight work. Good stacking discipline keeping the MoE Metal perf work separate from the core foundation.

Note this is gated on its base (#1034, jd/glm-dsa-llama-foundation) merging first — it can't land until then.

@i386
i386 force-pushed the jd/glm-moe-metal-active branch 2 times, most recently from 60ec824 to e40ac0d Compare July 22, 2026 05:18
@i386
i386 force-pushed the jd/glm-dsa-llama-foundation branch from e7fc73e to 6af4462 Compare July 23, 2026 20:58
@i386
i386 force-pushed the jd/glm-moe-metal-active branch from e40ac0d to f4c41ce Compare July 23, 2026 21:00
@i386
i386 deleted the branch jd/glm-dsa-llama-foundation July 23, 2026 21:26
@i386 i386 closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants