Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/skippy-ffi/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pub const ABI_VERSION_MAJOR: u32 = 0;
pub const ABI_VERSION_MINOR: u32 = 1;
pub const ABI_VERSION_PATCH: u32 = 31;
pub const ABI_VERSION_PATCH: u32 = 32;
pub const FEATURE_BACKEND_DEVICES: u64 = 1 << 23;
pub const FEATURE_RUNTIME_EVENTS: u64 = 1 << 24;
pub const FEATURE_NATIVE_MTP_N1: u64 = 1 << 25;
Expand Down Expand Up @@ -219,10 +219,18 @@ pub struct RuntimeConfig {
pub flash_attn_type: i32,
pub load_mode: LoadMode,
pub disable_repack: bool,
pub use_mmap_prefetch: bool,
pub use_mmap_buffer: bool,
pub filter_tensors_on_load: bool,
pub include_embeddings: bool,
pub include_output: bool,
pub selected_backend_device: *const c_char,
pub glm_dsa_policy_profile: i32,
pub glm_dsa_policy_flags: u32,
pub glm_dsa_short_prefill_max_tokens: i32,
pub glm_dsa_direct_sparse_decode_max_top_k: i32,
pub glm_dsa_dense_sparse_mask_max_bytes: u64,
pub glm_dsa_compact_flash_min_kv: i32,
}

#[repr(C)]
Expand Down
24 changes: 24 additions & 0 deletions crates/skippy-runtime/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,18 @@ impl RuntimeConfig {
flash_attn_type: self.flash_attn_type as i32,
load_mode: self.load_mode,
disable_repack: false,
use_mmap_prefetch: false,
use_mmap_buffer: false,
filter_tensors_on_load: self.filter_tensors_on_load,
include_embeddings: self.include_embeddings,
include_output: self.include_output,
selected_backend_device: selected_backend_device_ptr,
glm_dsa_policy_profile: 0,
glm_dsa_policy_flags: 0,
glm_dsa_short_prefill_max_tokens: 0,
glm_dsa_direct_sparse_decode_max_top_k: 0,
glm_dsa_dense_sparse_mask_max_bytes: 0,
glm_dsa_compact_flash_min_kv: 0,
},
_selected_backend_device: selected_backend_device,
})
Expand Down Expand Up @@ -311,6 +319,22 @@ mod tests {
Ok(())
}

#[test]
fn runtime_config_raw_defaults_glm_dsa_controls_to_disabled() -> anyhow::Result<()> {
let raw = RuntimeConfig::default().as_raw()?.raw;

assert!(!raw.use_mmap_prefetch);
assert!(!raw.use_mmap_buffer);
assert_eq!(raw.glm_dsa_policy_profile, 0);
assert_eq!(raw.glm_dsa_policy_flags, 0);
assert_eq!(raw.glm_dsa_short_prefill_max_tokens, 0);
assert_eq!(raw.glm_dsa_direct_sparse_decode_max_top_k, 0);
assert_eq!(raw.glm_dsa_dense_sparse_mask_max_bytes, 0);
assert_eq!(raw.glm_dsa_compact_flash_min_kv, 0);
assert!(raw.selected_backend_device.is_null());
Ok(())
}

#[test]
fn runtime_config_raw_uses_smaller_batch_for_unified_kv_defaults() -> anyhow::Result<()> {
let config = RuntimeConfig {
Expand Down
Loading
Loading