-
Notifications
You must be signed in to change notification settings - Fork 18
clarify call-home service and requirements #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tomasMizera
merged 9 commits into
main
from
548-adding-callback-network-requirements-to-docs
Mar 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f18e35f
clarify call-home service and requirements
fernandinand 791d881
Further refinement for telemetry service information #548
fernandinand a26b4bd
fix broken link and aspell
fernandinand 4c180ca
Minor refinment #564
fernandinand 908c3ae
Merge branch 'main' into 548-adding-callback-network-requirements-to-…
fernandinand 29ac04f
Add link to telemetry information
fernandinand 63e4b8f
Merge branch '548-adding-callback-network-requirements-to-docs' of gi…
fernandinand 8fb38bf
address remarks on GH
fernandinand 23030fe
make spellcheck happy
fernandinand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be part of the warning - warning is about legal bit - port is description how to set it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of the technical requirement, it should say that it requires outgoing https access to https://api.merginmaps.com/monitoring on TCP port 443
I think this page has some wider issues though - it looks like it's written as a call to action to disable monitoring (which we don't want). I would instead recommend: