-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add user management methods to py-client integration page #563
base: main
Are you sure you want to change the base?
Conversation
src/dev/integration.md
Outdated
@@ -40,24 +40,24 @@ client.create_user(<email>, <password>, <workspace_id>, <workspace_role>, [usern | |||
``` | |||
Arguments: | |||
`email` (str): Must be a unique email | |||
`passowrd` (str): Must meet security requirements. | |||
`passoword` (str): Must meet security requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still typo :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left some comments/suggestions.
``` | ||
|
||
#### User and roles management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this relevant only to the Python module or also to the Python command line interface? If both, this should be a subsection (### User and role management) and moved below the Python CLI subsection,
The #### level of subsection is in my opinion the last subsection level that looks okay. ##### subsections (that are used here) do not look very good when the page is compiled, so I would avoid using them. If it's necessary to structure the page this way, I would considering making separate pages for Python integration and C++ integration (to remove one level of subsections).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. the new commands are available only in the Python module so far. It'll be added to the CLI soon but the syntax is different anyway.
As the content will grow, the dedicated pages make sense.
client.create_user(<email>, <password>, <workspace_id>, <workspace_role>, [username], [notify_user]) | ||
``` | ||
Arguments: | ||
`email` (str): Must be a unique email |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try some other description instead of "unique email"? Maybe something like: "an email that is not yet used on the server" or "email not yet associated with an account"
Also, I would considering writing the data types in full (i.e. string, integer, etc.) to be consistent with this for instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1, sure - unique email
is confusing, indeed
2, shall we put the arguments in the table like in the link?
Resolves #553
Describe new possibilities of the python client:
User creation
create_user
Projects API
list_project_collaborators
add_project_collaborator
update_project_collaborator
remove_project_collaborator
Workspaces API
list_workspace_members
get_workspace_member
update_workspace_member
remove_workspace_member