Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some notes about Celery settings vars #561 #562

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fernandinand
Copy link
Contributor

To be reviewed...

@fernandinand fernandinand self-assigned this Feb 20, 2025
@fernandinand fernandinand linked an issue Feb 20, 2025 that may be closed by this pull request
```

## Celery settings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have these in troubleshooting section? Should not we at least mention few most common issues?
Also there is flask cmd to test if celery is working, worth mentioning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varmar05 Do you prefer a specific section for this or under 'Install' section?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basic settings we can have in 'install' section or with other env variables - ideally our default should be reasonable so users do not need to change anything (unless they know what they are doing)

but because of common issues with celery we should have some trouble shooting section as well - at least to verify that celery is running and accepting tasks

```

## Celery settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some troubleshooring context to this

@varmar05
Copy link
Collaborator

I would mention here mainly that BROKER URL needs to be correct and celery-beat, celery-worker containers should be up and running.

| `PROJECT_ACCESS_REQUEST` | integer | `604800` | Lifetime of active project access request in seconds. |
| `TEMP_EXPIRATION` | integer | `7` | Time in days after files in a temporary folder are permanently deleted. |
| Variable name | Type | Default | Description |
|------------------------------|----------|---------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm? too much ---- or is it ok?

@MarcelGeo
Copy link
Contributor

@alex-cit could you review spelling here, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Celery variables
3 participants