-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added section related to https deployment #556 #557
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think do not mention docker-compose here. As we discussed with @varmar05 , ssl-proxy.conf is just example of how to use it with nginx. You can follow this guide on your infrastructure. If you want to use it with docker-compose as you mentioned, ssl-proxy.conf should be updated also with specific paths from nginx.conf (/download , etc.)
I think that you can mention here also specific security headers from ssl-proxy.conf.
src/server/security/index.md
Outdated
|
||
The above example uses automated keys generated by CertBot. For more information, visit [CertBot](https://certbot.eff.org/instructions) website and check how you can generate your own keys. | ||
|
||
Lastly, adjust the provided NGINX `docker compose` deployment file on the <GitHubRepo id="MerginMaps/server/blob/master/docker-compose.yml" desc="proxy service section" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do not need to menion this CE docker-compose. Use just your docker-compose or something like this.
@@ -249,6 +253,7 @@ shapefiles | |||
spatialindex | |||
spatialite | |||
sqlite | |||
ssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use SSL?
src/server/security/index.md
Outdated
- ./projects:/data # map data dir to host | ||
- - ./nginx.conf:/etc/nginx/conf.d/default.conf | ||
+ - ./ssl-proxy.conf:/etc/nginx/conf.d/default.conf | ||
- ./logs:/var/log/nginx/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure If we want to discuss here also logs. There is no context for it.
src/server/security/index.md
Outdated
# Secure Mergin Maps installation | ||
|
||
::: warning | ||
This sections aims to provide some guidelines and a minimalistic example on how to secure a Mergin Maps deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sections aims to provide some guidelines and a minimalistic example on how to secure a Mergin Maps deployment. | |
This sections aims to provide some guidelines and a minimalistic example on how to secure a <MainPlatformName /> deployment. |
Please review this new section related to HTTPS deployment