feat: add assignees option to the copy and backport commands by v1v · Pull Request #2336 · Mergifyio/mergify

v1v · 2021-03-30T12:39:06Z

Description of the change

Add assignees option to the copy and backport commands

Related issues

Fix #2287

Checklists

Development

All checks must pass (Semantic Pull Request, pep8, requirements, unit tests, functional tests, security checks, …)
The code changed/added as part of this pull request must be covered with tests
Hotfixes must have a link to Sentry issue and the hotfix label
Features must have a link to a Linear task

Code Review

Code review policies are handled and automated by Mergify.

When all tests pass, reviewers will be assigned automatically.
When change is approved by at least one review and no pending review are
remaining, pull request is retested against its base branch.
The pull request is then merged automatically.

v1v · 2021-03-30T12:39:57Z

Similar to #2334.

I've no clue how to test this locally, though my changes in the test data were good enough 👑

sileht

Maybe we can be more generic like assign action does, for example:

voluptuous.Required("assignees", default[]: [types.Jinja2])

And then the configuration will look like this:

backport:
    assignees: ["{{ author }}"]

What do you think?

mergify · 2021-04-02T10:32:25Z

@v1v this pull request is now in conflict 😩

v1v · 2021-04-06T09:21:14Z

+        f.write(
+            f"""<head>
  <meta http-equiv="refresh" content="0; URL={url}">
  <link rel="canonical" href="{url}">
 </head>
-""")
+"""
+        )


Unrelated change caused by the tox -e black command

I will fix the tox target

v1v · 2021-04-06T09:29:42Z

I've just changed the implementation to use the suggestion from #2336 (review)

Though, I might need some help with the test data

sileht · 2021-04-06T09:36:50Z

Fixtures for the functional need to setup a GitHub app and a couple of GitHub accounts and API keys.

I will take care of it.

sileht

I just post some remarks, but I have already fixed them locally. You don't have to fix them.

I'm currently generating the fixtures.

sileht · 2021-04-07T08:28:47Z

            json={"labels": effective_labels},
        )

+    if assignees is not None:


Need also checks len(assignes) > 0 to avoid useless HTTP request

sileht · 2021-04-07T08:29:03Z

+        f.write(
+            f"""<head>
  <meta http-equiv="refresh" content="0; URL={url}">
  <link rel="canonical" href="{url}">
 </head>
-""")
+"""
+        )


I will fix the tox target

Pull request has been modified.

jd

Just small doc change

jd · 2021-04-08T08:49:22Z

+     - The users to assign to the pull request.

+The list of users in ``assignees`` is based on :ref:`data type template`, you can use
+e.g. ``{{author}}`` to assign the pull request to its author.


Suggested change

- The users to assign to the pull request.

The list of users in ``assignees`` is based on :ref:`data type template`, you can use

e.g. ``{{author}}`` to assign the pull request to its author.

- Users to assign the newly created pull request. As the type is :ref:`data type template`, you could use, e.g., ``{{author}}`` to assign the pull request to its original author.

jd · 2021-04-08T08:49:39Z

          backport:
            branches:
              - stable
+            assignees: ["{{ author }}"]


Suggested change

assignees: ["{{ author }}"]

assignees:

- "{{ author }}"

I feel it's more readable :)

jd · 2021-04-08T08:49:48Z

+   * - ``assignees``
+     - list of :ref:`data type template`
+     -
+     - The users to assign to the pull request.
+
+The list of users in ``assignees`` is based on :ref:`data type template`, you can use
+e.g. ``{{author}}`` to assign the pull request to its author.


Change like backport above.

Pull request has been modified.

mergify Bot requested a review from a team March 30, 2021 12:44

v1v marked this pull request as ready for review March 30, 2021 13:26

v1v mentioned this pull request Mar 30, 2021

[mergify] backport automation to 7.x, 7.12 and 7.11 elastic/beats#24608

Merged

3 tasks

sileht reviewed Apr 2, 2021

View reviewed changes

mergify Bot requested a review from a team April 2, 2021 08:07

mergify Bot added conflict and removed conflict labels Apr 2, 2021

v1v commented Apr 6, 2021

View reviewed changes

v1v force-pushed the feature/add-assignee-author-backport branch from e646b00 to 80754d1 Compare April 6, 2021 09:23

sileht changed the title ~~feat: add assign_author option to the copy and backport commands~~ feat: add author option to the copy and backport commands Apr 7, 2021

sileht changed the title ~~feat: add author option to the copy and backport commands~~ feat: add assignees option to the copy and backport commands Apr 7, 2021

sileht reviewed Apr 7, 2021

View reviewed changes

sileht force-pushed the feature/add-assignee-author-backport branch from 80754d1 to 90bf0c2 Compare April 7, 2021 09:43

sileht requested a review from jd April 7, 2021 09:43

sileht previously approved these changes Apr 7, 2021

View reviewed changes

mergify Bot requested a review from a team April 7, 2021 09:47

jd previously requested changes Apr 8, 2021

View reviewed changes

feat: add assignees option to the copy and backport commands

791fd5c

sileht force-pushed the feature/add-assignee-author-backport branch from 90bf0c2 to 791fd5c Compare April 8, 2021 08:56

mergify Bot requested a review from a team April 8, 2021 09:00

jd approved these changes Apr 8, 2021

View reviewed changes

mergify Bot merged commit 16ac33c into Mergifyio:master Apr 8, 2021

Uh oh!

Conversation

v1v commented Mar 30, 2021 • edited by sileht Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the change

Related issues

Checklists

Development

Code Review

Uh oh!

v1v commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sileht left a comment

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Apr 2, 2021

Uh oh!

v1v Apr 6, 2021

Choose a reason for hiding this comment

Uh oh!

sileht Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

v1v commented Apr 6, 2021

Uh oh!

sileht commented Apr 6, 2021

Uh oh!

sileht left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sileht Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

sileht Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

jd left a comment

Choose a reason for hiding this comment

Uh oh!

jd Apr 8, 2021

Choose a reason for hiding this comment

Uh oh!

jd Apr 8, 2021

Choose a reason for hiding this comment

Uh oh!

jd Apr 8, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

v1v commented Mar 30, 2021 •

edited by sileht

Loading

v1v commented Mar 30, 2021 •

edited

Loading