bintools: Add response file support to ld-wrapper#2
Merged
Gabriella439 merged 1 commit intoghc944-on-incremental-stdenv-fixfrom Feb 22, 2023
Merged
Conversation
The motivation behind this is to alleviate the problem described in NixOS#41340. I'm not sure if this completely fixes the problem, but it eliminates one more area where we can exceed command line length limits. This is essentially the same change as in NixOS#112449, except for `ld-wrapper.sh` instead of `cc-wrapper.sh`. However, that change alone was not enough; on macOS the `ld` provided by `darwin.cctools` fails if you use process substitution to generate the response file, so I put up two PRs to fix that: tpoechtrager/cctools-port#131 tpoechtrager/cctools-port#132 … and I included a patch referencing that fix so that the new `ld-wrapper` still works on macOS.
Author
|
For reference, the corresponding upstream PR against Nixpkgs is: NixOS#213831 |
9999years
approved these changes
Feb 22, 2023
9999years
pushed a commit
that referenced
this pull request
Jul 7, 2023
flutter: Separate cache and unwrapped derivations #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation behind this is to alleviate the problem described in NixOS#41340. I'm not sure if this completely fixes the problem, but it eliminates one more area where we can exceed command line length limits.
This is essentially the same change as in NixOS#112449, except for
ld-wrapper.shinstead ofcc-wrapper.sh.However, that change alone was not enough; on macOS the
ldprovided bydarwin.cctoolsfails if you use process substitution to generate the response file, so I put up two PRs to fix that:tpoechtrager/cctools-port#131
tpoechtrager/cctools-port#132
… and I included a patch referencing that fix so that the new
ld-wrapperstill works on macOS.