Add bash support
#23
Merged
Add bash support
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
deleted the
rebeccat/dux-1092-add-bash-support-to-nix-your-shell
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little weird, because
bashis the default shell Nix uses. However, we're currently seeing a bug wherenix developwill exit if any command being run exits with a nonzero exit code, butnix develop --command bashwill not. Weird!EDIT: The bug was caused by sourcing scripts created with
writeShellApplicationinstead ofwriteShellScriptBinin the Nix shell'sshellHook, causingset -eubeing sourced at the beginning of the shell. This in turn caused any failing command to exit the shell. I'm still going to merge this though becausebashsupport won't hurt anyone.