fix: support decoding data URL in Node < v16 #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to publish code that works on Node.js and web browsers alike, and I would like to support Node v14, which reaches EOL on April 2023. However, Node < v16 do not provide a global
atob()
function for decoding base64 strings, and must useBuffer.from()
instead. (See docs foratob()
)Furthermore,
Buffer.from(str, 'base64').toString()
is much faster thanatob()
in Node:This is because
atob()
is intentionally unoptimized. (See rationale)Thus, we should prefer
Buffer.from()
whenever it is available.This PR uses
Buffer.from()
if it is available, andatob()
otherwise. In the rare event that neither exists, the code throws an Error.