feat(eval): add run locomo eval script - #28
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new shell script to sequentially run all steps of the Locomo evaluation pipeline.
- Adds
run_locomo_eval.shto orchestrate ingestion, search, response generation, evaluation, and metric calculation. - Sets default parameters (
LIB,VERSION,WORKERS,TOPK) and checks exit codes for each step.
| @@ -0,0 +1,44 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Consider adding set -euo pipefail after the shebang to ensure the script exits on any error and detects undefined variables.
Comment on lines
+9
to
+42
| echo "Running locomo_ingestion.py..." | ||
| CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_ingestion.py --lib $LIB --version $VERSION --workers $WORKERS | ||
| if [ $? -ne 0 ]; then | ||
| echo "Error running locomo_ingestion.py" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Running locomo_search.py..." | ||
| CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_search.py --lib $LIB --version $VERSION --top_k $TOPK --workers $WORKERS | ||
| if [ $? -ne 0 ]; then | ||
| echo "Error running locomo_search.py" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Running locomo_responses.py..." | ||
| python scripts/locomo/locomo_responses.py --lib $LIB --version $VERSION | ||
| if [ $? -ne 0 ]; then | ||
| echo "Error running locomo_responses.py." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Running locomo_eval.py..." | ||
| python scripts/locomo/locomo_eval.py --lib $LIB --version $VERSION --workers $WORKERS --num_runs 3 | ||
| if [ $? -ne 0 ]; then | ||
| echo "Error running locomo_eval.py" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Running locomo_metric.py..." | ||
| python scripts/locomo/locomo_metric.py --lib $LIB --version $VERSION | ||
| if [ $? -ne 0 ]; then | ||
| echo "Error running locomo_metric.py" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
[nitpick] The error-checking and execution pattern is repeated for each script; consider extracting a helper function (e.g., run_step) to reduce duplication and improve readability.
Suggested change
| echo "Running locomo_ingestion.py..." | |
| CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_ingestion.py --lib $LIB --version $VERSION --workers $WORKERS | |
| if [ $? -ne 0 ]; then | |
| echo "Error running locomo_ingestion.py" | |
| exit 1 | |
| fi | |
| echo "Running locomo_search.py..." | |
| CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_search.py --lib $LIB --version $VERSION --top_k $TOPK --workers $WORKERS | |
| if [ $? -ne 0 ]; then | |
| echo "Error running locomo_search.py" | |
| exit 1 | |
| fi | |
| echo "Running locomo_responses.py..." | |
| python scripts/locomo/locomo_responses.py --lib $LIB --version $VERSION | |
| if [ $? -ne 0 ]; then | |
| echo "Error running locomo_responses.py." | |
| exit 1 | |
| fi | |
| echo "Running locomo_eval.py..." | |
| python scripts/locomo/locomo_eval.py --lib $LIB --version $VERSION --workers $WORKERS --num_runs 3 | |
| if [ $? -ne 0 ]; then | |
| echo "Error running locomo_eval.py" | |
| exit 1 | |
| fi | |
| echo "Running locomo_metric.py..." | |
| python scripts/locomo/locomo_metric.py --lib $LIB --version $VERSION | |
| if [ $? -ne 0 ]; then | |
| echo "Error running locomo_metric.py" | |
| exit 1 | |
| fi | |
| # Helper function to run a script and check for errors | |
| run_step() { | |
| local script=$1 | |
| shift | |
| echo "Running $script..." | |
| "$@" | |
| if [ $? -ne 0 ]; then | |
| echo "Error running $script" | |
| exit 1 | |
| fi | |
| } | |
| run_step "locomo_ingestion.py" CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_ingestion.py --lib $LIB --version $VERSION --workers $WORKERS | |
| run_step "locomo_search.py" CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_search.py --lib $LIB --version $VERSION --top_k $TOPK --workers $WORKERS | |
| run_step "locomo_responses.py" python scripts/locomo/locomo_responses.py --lib $LIB --version $VERSION | |
| run_step "locomo_eval.py" python scripts/locomo/locomo_eval.py --lib $LIB --version $VERSION --workers $WORKERS --num_runs 3 | |
| run_step "locomo_metric.py" python scripts/locomo/locomo_metric.py --lib $LIB --version $VERSION |
tianxing02
pushed a commit
to tianxing02/MemOS
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
run locomo evalscript, submitting a supplement now. @Ki-SekiHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist