Skip to content

Adjust feedback update review flow & unify LLM provider environment config #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bittergreen merged 8 commits into from
Jul 22, 2026
Merged

Adjust feedback update review flow & unify LLM provider environment config #2135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
639355c
fix: Adjust feedback update review flow & using independent
bittergreen Jul 21, 2026
20c27ce
refactor: unify LLM provider environment config
bittergreen Jul 21, 2026
82b02a2
fix: fix log for embedding models
bittergreen Jul 21, 2026
d9e2f5d
fix: fix tests
bittergreen Jul 22, 2026
a0e444b
fix: preserve text when downgrading feedback updates
bittergreen Jul 22, 2026
b686710
fix: type parser factory config as base parser config
bittergreen Jul 22, 2026
0286120
fix: Open Code Review problems fix
bittergreen Jul 22, 2026
8edb28f
Merge branch 'dev-v2.0.25' into wq-dev-v2.0.25
bittergreen Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion evaluation/.env-example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# memory process model
MODEL="gpt-4o-mini"
OPENAI_API_KEY="sk-***REDACTED***"
OPENAI_BASE_URL="http://***.***.***.***:3000/v1"
OPENAI_API_BASE="http://***.***.***.***:3000/v1"


# response model
Expand Down
2 changes: 1 addition & 1 deletion evaluation/scripts/PrefEval/pref_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
load_dotenv()

API_KEY = os.getenv("OPENAI_API_KEY")
API_URL = os.getenv("OPENAI_BASE_URL")
API_URL = os.getenv("OPENAI_API_BASE")


async def call_gpt4o_mini_async(client: OpenAI, prompt: str) -> str:
Expand Down
2 changes: 1 addition & 1 deletion evaluation/scripts/PrefEval/pref_mem0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
sys.path.insert(0, EVAL_SCRIPTS_DIR)
load_dotenv()
OPENAI_API_KEY = os.getenv("OPENAI_API_KEY")
BASE_URL = os.getenv("OPENAI_BASE_URL")
BASE_URL = os.getenv("OPENAI_API_BASE")
MODEL_NAME = os.getenv("MODEL_NAME", "gpt-4o-mini")
tokenizer = tiktoken.get_encoding("cl100k_base")
os.environ["MEM0_API_KEY"] = os.getenv("MEM0_API_KEY")
Expand Down
2 changes: 1 addition & 1 deletion evaluation/scripts/PrefEval/pref_memobase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
sys.path.insert(0, EVAL_SCRIPTS_DIR)
load_dotenv()
OPENAI_API_KEY = os.getenv("OPENAI_API_KEY")
BASE_URL = os.getenv("OPENAI_BASE_URL")
BASE_URL = os.getenv("OPENAI_API_BASE")
MODEL_NAME = os.getenv("MODEL_NAME", "gpt-4o-mini")
tokenizer = tiktoken.get_encoding("cl100k_base")

Expand Down
2 changes: 1 addition & 1 deletion evaluation/scripts/PrefEval/pref_memos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

load_dotenv()
OPENAI_API_KEY = os.getenv("OPENAI_API_KEY")
BASE_URL = os.getenv("OPENAI_BASE_URL")
BASE_URL = os.getenv("OPENAI_API_BASE")
MODEL_NAME = os.getenv("MODEL_NAME", "gpt-4o-mini")
tokenizer = tiktoken.get_encoding("cl100k_base")

Expand Down
2 changes: 1 addition & 1 deletion evaluation/scripts/PrefEval/pref_memu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
sys.path.insert(0, EVAL_SCRIPTS_DIR)
load_dotenv()
OPENAI_API_KEY = os.getenv("OPENAI_API_KEY")
BASE_URL = os.getenv("OPENAI_BASE_URL")
BASE_URL = os.getenv("OPENAI_API_BASE")
MODEL_NAME = os.getenv("MODEL_NAME", "gpt-4o-mini")
tokenizer = tiktoken.get_encoding("cl100k_base")

Expand Down
2 changes: 1 addition & 1 deletion evaluation/scripts/PrefEval/pref_supermemory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
sys.path.insert(0, EVAL_SCRIPTS_DIR)
load_dotenv()
OPENAI_API_KEY = os.getenv("OPENAI_API_KEY")
BASE_URL = os.getenv("OPENAI_BASE_URL")
BASE_URL = os.getenv("OPENAI_API_BASE")
MODEL_NAME = os.getenv("MODEL_NAME", "gpt-4o-mini")
tokenizer = tiktoken.get_encoding("cl100k_base")

Expand Down
2 changes: 1 addition & 1 deletion evaluation/scripts/PrefEval/pref_zep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
sys.path.insert(0, EVAL_SCRIPTS_DIR)
load_dotenv()
OPENAI_API_KEY = os.getenv("OPENAI_API_KEY")
BASE_URL = os.getenv("OPENAI_BASE_URL")
BASE_URL = os.getenv("OPENAI_API_BASE")
MODEL_NAME = os.getenv("MODEL_NAME", "gpt-4o-mini")
tokenizer = tiktoken.get_encoding("cl100k_base")

Expand Down
2 changes: 1 addition & 1 deletion evaluation/scripts/locomo/locomo_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ async def main(frame, version="default", options=None, num_runs=1, max_workers=4

load_dotenv()
oai_client = AsyncOpenAI(
api_key=os.getenv("OPENAI_API_KEY"), base_url=os.getenv("OPENAI_BASE_URL")
api_key=os.getenv("OPENAI_API_KEY"), base_url=os.getenv("OPENAI_API_BASE")
)

with open(response_path) as file:
Expand Down
Loading
Loading