Skip to content

fix(product): Correctly handle nested memory structure in chat methods #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
muzzlol wants to merge 3 commits into from
Closed

fix(product): Correctly handle nested memory structure in chat methods #148

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1d4a2e
fix(product): Correctly handle nested memory structure in chat methods
muzzlol Jul 23, 2025
721166f
ran format
muzzlol Jul 24, 2025
9898551
Merge branch 'main' into fix/nested-data-handling
CaralHsi Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/memos/mem_os/product.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,12 +717,13 @@ def chat(

# Prepare reference data
reference = []
for memories in memories_list:
memories_json = memories.model_dump()
memories_json["metadata"]["ref_id"] = f"[{memories.id.split('-')[0]}]"
memories_json["metadata"]["embedding"] = []
memories_json["metadata"]["sources"] = []
reference.append(memories_json)
for memories_dict in memories_list:
for memory_item in memories_dict["memories"]:
memory_json = memory_item.model_dump()
memory_json["metadata"]["ref_id"] = f"[{memory_item.id.split('-')[0]}]"
memory_json["metadata"]["embedding"] = []
memory_json["metadata"]["sources"] = []
reference.append(memory_json)

yield f"data: {json.dumps({'type': 'reference', 'content': reference})}\n\n"
total_time = round(float(time_end - time_start), 1)
Expand Down Expand Up @@ -843,13 +844,14 @@ def chat_with_references(

# Prepare reference data
reference = []
for memories in memories_list:
memories_json = memories.model_dump()
memories_json["metadata"]["ref_id"] = f"{memories.id.split('-')[0]}"
memories_json["metadata"]["embedding"] = []
memories_json["metadata"]["sources"] = []
memories_json["metadata"]["memory"] = memories.memory
reference.append({"metadata": memories_json["metadata"]})
for memories_dict in memories_list:
for memory_item in memories_dict["memories"]:
memory_json = memory_item.model_dump()
memory_json["metadata"]["ref_id"] = f"[{memory_item.id.split('-')[0]}]"
memory_json["metadata"]["embedding"] = []
memory_json["metadata"]["sources"] = []
memory_json["metadata"]["memory"] = memory_item.memory
reference.append({"metadata": memory_json["metadata"]})

yield f"data: {json.dumps({'type': 'reference', 'data': reference})}\n\n"
total_time = round(float(time_end - time_start), 1)
Expand Down