hooks: honor silent_save for autosave hooks - #966
Closed
PostProtoroman wants to merge 1 commit into
Closed
Conversation
Contributor
|
The core change here (honoring #673 implements the same two-layer design: Layer 1 is a direct jphein's 2026-04-16 comment on #854 frames #673 against adjacent PRs:
#673 is dirty against develop after #863 landed; jphein offered there to rebase. Two aspects of #966 that are not in #673:
|
jphein
added a commit
to techempower-org/mempalace
that referenced
this pull request
Apr 18, 2026
Upstream v3.3.1 headline: multi-language entity detection (PT-BR, Russian, Italian, Hindi, Indonesian, Chinese), BCP-47 case-insensitive locale resolution, UTF-8 encoding fix for non-UTF-8 Windows locales, combining-mark word-boundary fix for Devanagari/Arabic/Hebrew/Thai scripts. Also absorbs PR MemPalace#966 (honor silent_save), MemPalace#863 (precompact blocking fix), MemPalace#895/MemPalace#897 (benchmarks + README rewrite), MemPalace#946 (UTF-8 Path.read_text), and more. Conflict resolutions: - mempalace/hooks_cli.py: kept fork-only _desktop_toast + _mempalace_python (hook wrappers depend on these), adopted upstream's _get_mine_dir helper + _mine_sync function + _maybe_auto_ingest(transcript_path) signature, kept fork's silent-save MempalaceConfig branch, kept _ingest_transcript call in hook_precompact before the new _mine_sync so the session JSONL still gets captured on precompact. - tests/test_hooks_cli.py: merged both import sets. Updated test_stop_hook_rejects_injected_stop_hook_active to accept either the silent-save systemMessage output or the legacy decision=block — the security property (don't treat injected stop_hook_active as truthy) holds for both modes. - tests/test_miner.py: merged both import sets (CHUNK_* constants + load_config). - tests/test_readme_claims.py: accepted upstream's shift from README parsing to website/reference/mcp-tools.md and modules.md — website docs are now the source of truth for the tool table. - mempalace/entity_detector.py: accepted upstream wholesale — replaces hardcoded English STOPWORDS with i18n-JSON-backed patterns and backward- compat module constants. - README.md: kept fork README, bumped version badge 3.3.0 → 3.3.1. Verification: 995 tests pass, stop hook fires end-to-end ("✦ 13 memories woven into the palace"), 10/10 fresh-process palace opens + queries OK. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jphein
added a commit
to techempower-org/mempalace
that referenced
this pull request
Apr 18, 2026
- Bump fork-target tag and drawer count (v3.3.0 → v3.3.1, 134K → 135K) - Add "Pulled in from upstream v3.3.1" section: i18n entity detection, BCP-47 locale resolution, script-aware boundaries, UTF-8 Path.read_text, non-blocking precompact (MemPalace#863), basic silent_save honoring (MemPalace#966) - Note that our MemPalace#673 silent-save is still ahead of upstream's MemPalace#966: marker-after-confirmed-save, themes extraction, systemMessage - Add Mintlify to the memory-system comparison table (docs platform pitched as "self-updating knowledge management" with MCP support; not a verbatim personal memory tool, but shares the framing) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
jphein
added a commit
to techempower-org/mempalace
that referenced
this pull request
Apr 18, 2026
README: - Bump drawer count 134K → 137K (matches current palace) - Update "Open upstream PRs" table with actual reviewer status, add MemPalace#999 and MemPalace#1000, drop stale "rebased against MemPalace#863" note since MemPalace#863 is in v3.3.1 CLAUDE.md: - Rename section header v3.3.0 → v3.3.1 (we merged v3.3.1 earlier today) - Add fork changes 11-13: None-metadata guards, .blob_seq_ids_migrated marker, quarantine_stale_hnsw - Replace "Pulled in from upstream v3.3.1" summary: i18n, BCP-47 locales, UTF-8 Path.read_text, non-blocking precompact (MemPalace#863), silent_save honoring (MemPalace#966) — ours still broader - Update the open-upstream-PRs table to 7 open, include MemPalace#999 + MemPalace#1000 and refresh each row's status line to match what's actually on GitHub (MERGEABLE flags, @bensig ping context, Copilot review addressed, etc.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
igorls
added
enhancement
Member
|
Hi, thanks for the contribution. This PR has merge conflicts with Could you rebase onto If this change is no longer relevant, feel free to close the PR. (This message is part of a periodic backlog pass, sent to all open PRs that match this state.) |
igorls
added
the
needs-rebase
Author
|
sorry guys, it was made by mistake. unfortunately found it a bit late.
On Friday, May 8, 2026 at 06:58:45 PM GMT+8, Igor Lins e Silva ***@***.***> wrote:
igorls left a comment (MemPalace/mempalace#966)
Hi, thanks for the contribution.
This PR has merge conflicts with develop, and the branch has not been updated in over 7 days, which puts it before our most recent release. The conflicts are likely against work that landed in that release.
Could you rebase onto develop so we can take another look?
If this change is no longer relevant, feel free to close the PR.
(This message is part of a periodic backlog pass, sent to all open PRs that match this state.)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation